Feat/donate native wc subs #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoo
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Seems to work insofar as it successfully processes the Stripe transactions with Automattic/newspack-plugin#2251.
|
@adekbadek are there any particular drawbacks to using the Source method instead of Payment Methods? |
|
I don't think so, apart from the fact that it's not recommended. But we are blocked here by WC Stripe Gateway using the Sources API for subscriptions. |
matticbot
pushed a commit
that referenced
this pull request
Feb 17, 2023
# [1.63.0-alpha.1](v1.62.0...v1.63.0-alpha.1) (2023-02-17) ### Bug Fixes * attribute types for custom author fields ([#1365](#1365)) ([483e49c](483e49c)) * remove mark background in Newspack blocks ([#1363](#1363)) ([295b7d1](295b7d1)) ### Features * **donate-block:** native wc subs ([#1359](#1359)) ([9834aa0](9834aa0))
|
🎉 This PR is included in version 1.63.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
6 tasks
matticbot
pushed a commit
that referenced
this pull request
Feb 28, 2023
# [1.63.0](v1.62.0...v1.63.0) (2023-02-28) ### Bug Fixes * attribute types for custom author fields ([#1365](#1365)) ([483e49c](483e49c)) * remove mark background in Newspack blocks ([#1363](#1363)) ([295b7d1](295b7d1)) ### Features * **donate-block:** native wc subs ([#1359](#1359)) ([9834aa0](9834aa0))
|
🎉 This PR is included in version 1.63.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
See and follow instructions in Automattic/newspack-plugin#2251
Other information: