Stripe: create native WC Subscriptions (if a flag is set) #2251

adekbadek · 2023-01-26T11:59:41Z

All Submissions:

Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Changes the way Stripe donations are handled, so that it's possible that instead of a Stripe Subscription, a WC Subscriptions' Subscription is created for recurring payments.

There is an underlying change in how Stripe API is interacted with. The way to charge a customer is either through Sources, Tokens, or Payment Methods – the latter replaces the former two. This integration has used Payment Methods, but since WC Stripe Gateway uses a Source to process WC Subscriptions renewals, the integration was updated to use Sources instead of Payment Methods.

How to test the changes in this Pull Request:

There are two ways to pay, and two modes of payment. When testing, ideally test all four scenarios (let's name them with letters for easier communication):

	Once	Recurring (e.g. monthly)
Card form	A	B
PaymentRequest (e.g. Apple Pay)	C	D

Set up Stripe, ensure the site is reachable by Stripe webhooks
Ensure the WC suite is active, and "Stripe – Credit Card (Stripe)" set as the sole payment method in WC
Test the payment scenarios for regressions – the recurring payments should result in Stripe Subscriptions shadowed by sync'd WC Subscriptions (which can't be edited, etc.)
Set the NEWSPACK_USE_WC_SUBSCRIPTIONS_WITH_STRIPE_PLATFORM environment flag to true
Test the payment scenarios with this new configuration – recurring payments should result in WC Subscriptions and one-time charges in Stripe (not Stripe Subscriptions)
Open the WC Subscriptions (scenarios B & D) in WP admin renew them manually (via the "Subscription actions" meta box)
Observe that the two subscriptions were renewed:
1. Each got a new Stripe charge (successful)
2. Each got a renewal order in WC
Disable the Stripe gateway in WC, observe that a recurring donation results in a Stripe Subscription

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?

- create a source on payment, for future charges made by WCS - create an order on processing donation - update the order on webhook callback (when the charge happens)

PMs are only needed for Stripe Subscriptions.

WC Stripe Gateway uses sources, not payment methods.

dkoo

I wasn't able to get through all of the testing steps. Perhaps some of these are due to user error or incorrect config on my test site, and maybe others are due to changes from other branches. Here's what I saw:

Manually renewing a Woo subscription:

Open the WC Subscriptions (scenarios B & D) in WP admin renew them manually (via the "Subscription actions" meta box)

When I did this, it resulted in a pending order being added to the subscription. The order never seems to complete. Because the order hangs as pending, the subscription status is changed to "On Hold", and a transaction never occurs on Stripe.

Custom metadata fields don't seem to be fully syncing. On master, I see all the NP_ fields being synced, but on this branch only a few are:

I wonder if this is due to these changes (1, 2) to the custom fields? I tried rebasing against master but that didn't change anything for me.

I wasn't able to test the C & D scenarios (PaymentIntent). Do we have a way to test these payment methods without requiring a real credit card transaction?

includes/reader-revenue/stripe/class-stripe-connection.php

adekbadek · 2023-02-01T13:14:08Z

When I did [manually renew a Woo subscription] it resulted in a pending order being added to the subscription. The order never seems to complete.

The order is created synchronously (as pending), but it's completed on webhook callback. Can you make sure the site is reachable for Stripe's webhook requests? Alternatively, maybe there's a PHP error logged during the webhook request?

Custom metadata fields don't seem to be fully syncing.

Good catch! This led me to fix an unidiomatic use of WC's order items (2621c96 – an order item has to be unique). But for the most part, the ESP data syncing is fixed in be22c5f.

I wasn't able to test the C & D scenarios (PaymentIntent). Do we have a way to test these payment methods without requiring a real credit card transaction?

As long as Stripe is configured to use test mode, you can test with real payment details and you won't be charged. See https://support.stripe.com/questions/testing-apple-pay-with-stripe

includes/reader-revenue/class-woocommerce-connection.php

dkoo · 2023-02-01T23:19:24Z

The order is created synchronously (as pending), but it's completed on webhook callback. Can you make sure the site is reachable for Stripe's webhook requests? Alternatively, maybe there's a PHP error logged during the webhook request?

I'm not seeing any PHP error resulting from the renewal, and in fact I don't see any webhook request in the Stripe dashboard when I process a renewal from the WooCommerce Subscription page. Is there another way I should try manually renewing the subscription? This is what I'm using:

dkoo · 2023-02-01T23:29:37Z

Good catch! This led me to fix an unidiomatic use of WC's order items (2621c96 – an order item has to be unique). But for the most part, the ESP data syncing is fixed in be22c5f.

Can confirm that the data syncing is fixed, now!

Without RAS enabled, the WP user won't be created on donation.

adekbadek · 2023-02-02T10:20:02Z

Fixed a dependency on RAS in b56ad32. If RAS is not enabled, a user account will not be created on donation, so the code here needs to create one (WP User is required to set up a WC Subscription).

dkoo

I'm going to approve this since the only outstanding issues seem to be related to my testing environment. Thanks for the fixes!

See Automattic/newspack-plugin#2251

# [1.103.0-alpha.2](v1.103.0-alpha.1...v1.103.0-alpha.2) (2023-02-17) ### Bug Fixes * **ads-wizard:** cancelled state of unit displayed on the list ([#2272](#2272)) ([e10b592](e10b592)) * **ads:** remove fixed height setting ([#2255](#2255)) ([0031b89](0031b89)) * change default auth strategy to "link" ([#2261](#2261)) ([c4b2e2c](c4b2e2c)) * update package.json to resolve a merge conflict with master ([f2408a3](f2408a3)) * **webhooks:** check if endpoint exists ([#2276](#2276)) ([5a95e2c](5a95e2c)) ### Features * bootstrap GA4 connector ([#2241](#2241)) ([f7582a4](f7582a4)) * **data-events:** mailchimp connector ([#2233](#2233)) ([08060c6](08060c6)) * **data-events:** standardize the use of "user_id" and "email" ([#2263](#2263)) ([d6b6903](d6b6903)) * **donations:** add payment metadata and update renewal description ([#2254](#2254)) ([b039304](b039304)) * **my-account:** display stripe billing link regardless of RR platform ([df540fe](df540fe)) * **perfmatters:** defaults adjustments, remove feature flag ([#2271](#2271)) ([cf5ad51](cf5ad51)) * **performance:** minify all inline CSS ([#2239](#2239)) ([fbb415f](fbb415f)) * **ras:** enable custom contact metadata prefixes ([#2249](#2249)) ([e9843e4](e9843e4)) * require all woo plugins for RAS ([#2260](#2260)) ([5f6a818](5f6a818)) * **stripe:** create native WC Subscriptions (if feature flag is set) ([#2251](#2251)) ([009a8a5](009a8a5)) * **webhooks:** support label for endpoints ([#2262](#2262)) ([39da7be](39da7be))

matticbot · 2023-02-17T10:05:45Z

🎉 This PR is included in version 1.103.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.104.0-alpha.1](v1.103.0...v1.104.0-alpha.1) (2023-02-17) ### Bug Fixes * **ads-wizard:** cancelled state of unit displayed on the list ([#2272](#2272)) ([e10b592](e10b592)) * **ads:** remove fixed height setting ([#2255](#2255)) ([0031b89](0031b89)) * change default auth strategy to "link" ([#2261](#2261)) ([c4b2e2c](c4b2e2c)) * **webhooks:** check if endpoint exists ([#2276](#2276)) ([5a95e2c](5a95e2c)) ### Features * bootstrap GA4 connector ([#2241](#2241)) ([f7582a4](f7582a4)) * **data-events:** mailchimp connector ([#2233](#2233)) ([08060c6](08060c6)) * **data-events:** standardize the use of "user_id" and "email" ([#2263](#2263)) ([d6b6903](d6b6903)) * **donations:** add payment metadata and update renewal description ([#2254](#2254)) ([b039304](b039304)) * **my-account:** display stripe billing link regardless of RR platform ([df540fe](df540fe)) * **perfmatters:** defaults adjustments, remove feature flag ([#2271](#2271)) ([cf5ad51](cf5ad51)) * **performance:** minify all inline CSS ([#2239](#2239)) ([fbb415f](fbb415f)) * **ras:** enable custom contact metadata prefixes ([#2249](#2249)) ([e9843e4](e9843e4)) * require all woo plugins for RAS ([#2260](#2260)) ([5f6a818](5f6a818)) * **stripe:** create native WC Subscriptions (if feature flag is set) ([#2251](#2251)) ([009a8a5](009a8a5)) * **webhooks:** support label for endpoints ([#2262](#2262)) ([39da7be](39da7be))

matticbot · 2023-02-17T11:02:30Z

🎉 This PR is included in version 1.104.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.105.0-alpha.1](v1.104.0...v1.105.0-alpha.1) (2023-02-20) ### Bug Fixes * **ads-wizard:** cancelled state of unit displayed on the list ([#2272](#2272)) ([e10b592](e10b592)) * **ads:** remove fixed height setting ([#2255](#2255)) ([0031b89](0031b89)) * change default auth strategy to "link" ([#2261](#2261)) ([c4b2e2c](c4b2e2c)) * **webhooks:** check if endpoint exists ([#2276](#2276)) ([5a95e2c](5a95e2c)) ### Features * bootstrap GA4 connector ([#2241](#2241)) ([f7582a4](f7582a4)) * **data-events:** mailchimp connector ([#2233](#2233)) ([08060c6](08060c6)) * **data-events:** standardize the use of "user_id" and "email" ([#2263](#2263)) ([d6b6903](d6b6903)) * **donations:** add payment metadata and update renewal description ([#2254](#2254)) ([b039304](b039304)) * **my-account:** display stripe billing link regardless of RR platform ([df540fe](df540fe)) * **perfmatters:** defaults adjustments, remove feature flag ([#2271](#2271)) ([cf5ad51](cf5ad51)) * **performance:** minify all inline CSS ([#2239](#2239)) ([fbb415f](fbb415f)) * **ras:** enable custom contact metadata prefixes ([#2249](#2249)) ([e9843e4](e9843e4)) * require all woo plugins for RAS ([#2260](#2260)) ([5f6a818](5f6a818)) * **stripe:** create native WC Subscriptions (if feature flag is set) ([#2251](#2251)) ([009a8a5](009a8a5)) * **webhooks:** support label for endpoints ([#2262](#2262)) ([39da7be](39da7be))

matticbot · 2023-02-20T10:10:55Z

🎉 This PR is included in version 1.105.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Stripe Subscriptions created before the changes in #2251 will not have a Source, but the customer will have PaymentMethods. These changes ensure that these customers' subscriptions can be migrated. This also means that not all changes from #2251 are necessary – Stripe Payment Gateway creates sources, but will handle a PaymentMethod ID if set as the source ID in the subscription metadata.

matticbot · 2023-02-27T10:38:59Z

🎉 This PR is included in version 1.105.0-hotfix-hpb-amp-optimisations.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.105.0](v1.104.1...v1.105.0) (2023-02-28) ### Bug Fixes * **ads-wizard:** cancelled state of unit displayed on the list ([#2272](#2272)) ([e10b592](e10b592)) * **ads:** remove fixed height setting ([#2255](#2255)) ([0031b89](0031b89)) * change default auth strategy to "link" ([#2261](#2261)) ([c4b2e2c](c4b2e2c)) * **webhooks:** check if endpoint exists ([#2276](#2276)) ([5a95e2c](5a95e2c)) ### Features * bootstrap GA4 connector ([#2241](#2241)) ([f7582a4](f7582a4)) * **data-events:** mailchimp connector ([#2233](#2233)) ([08060c6](08060c6)) * **data-events:** standardize the use of "user_id" and "email" ([#2263](#2263)) ([d6b6903](d6b6903)) * **donations:** add payment metadata and update renewal description ([#2254](#2254)) ([b039304](b039304)) * **my-account:** display stripe billing link regardless of RR platform ([df540fe](df540fe)) * **perfmatters:** defaults adjustments, remove feature flag ([#2271](#2271)) ([cf5ad51](cf5ad51)) * **performance:** minify all inline CSS ([#2239](#2239)) ([fbb415f](fbb415f)) * **ras:** enable custom contact metadata prefixes ([#2249](#2249)) ([e9843e4](e9843e4)) * require all woo plugins for RAS ([#2260](#2260)) ([5f6a818](5f6a818)) * **stripe:** create native WC Subscriptions (if feature flag is set) ([#2251](#2251)) ([009a8a5](009a8a5)) * **webhooks:** support label for endpoints ([#2262](#2262)) ([39da7be](39da7be))

matticbot · 2023-02-28T13:10:14Z

🎉 This PR is included in version 1.105.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

As it turns out, not all changes from #2251 are necessary – Stripe Payment Gateway creates sources, but will handle a PaymentMethod ID if set as the source ID in the subscription metadata.

# [1.106.0-alpha.1](v1.105.0...v1.106.0-alpha.1) (2023-03-03) ### Bug Fixes * **ads:** gam api availability according to error type ([#2289](#2289)) ([024fe08](024fe08)) ### Features * add a Add new button to subscription lists ([#2314](#2314)) ([9543ad2](9543ad2)) * add ga4 user registered handler ([#2281](#2281)) ([5eb2336](5eb2336)) * add pid to Logger ([#2290](#2290)) ([fd3011c](fd3011c)) * Add popup info to donations ([#2300](#2300)) ([7ea800b](7ea800b)) * allow external links in dashboard via a filter ([#2279](#2279)) ([3943b1a](3943b1a)) * campaigns listeners for the data events api ([#2291](#2291)) ([ab407d4](ab407d4)) * disable save button for unchanged settings ([#2259](#2259)) ([e06d72f](e06d72f)), closes [#1531](#1531) * **donate-block:** support modal checkout ([#2256](#2256)) ([34226dd](34226dd)) * Normalize donation events ([#2299](#2299)) ([2624d53](2624d53)) * **perfmatters:** improve config ([267306e](267306e)) * prevent homepage from being unpublished ([#2307](#2307)) ([a151d53](a151d53)) * Remove the campaign rendered event ([#2301](#2301)) ([23caa1d](23caa1d)) * Stripe Subscriptions to WC subscriptions migrator ([#2298](#2298)) ([6904356](6904356)), closes [#2251](#2251) * **wc:** force allowing subscription switching ([#2305](#2305)) ([c13e741](c13e741))

# [1.106.0](v1.105.1...v1.106.0) (2023-03-14) ### Bug Fixes * **ads:** gam api availability according to error type ([#2289](#2289)) ([024fe08](024fe08)) * show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([1173b5b](1173b5b)) ### Features * add a Add new button to subscription lists ([#2314](#2314)) ([9543ad2](9543ad2)) * add ga4 user registered handler ([#2281](#2281)) ([5eb2336](5eb2336)) * add pid to Logger ([#2290](#2290)) ([fd3011c](fd3011c)) * Add popup info to donations ([#2300](#2300)) ([7ea800b](7ea800b)) * allow external links in dashboard via a filter ([#2279](#2279)) ([3943b1a](3943b1a)) * campaigns listeners for the data events api ([#2291](#2291)) ([ab407d4](ab407d4)) * disable save button for unchanged settings ([#2259](#2259)) ([e06d72f](e06d72f)), closes [#1531](#1531) * **donate-block:** support modal checkout ([#2256](#2256)) ([34226dd](34226dd)) * Normalize donation events ([#2299](#2299)) ([2624d53](2624d53)) * **perfmatters:** improve config ([267306e](267306e)) * prevent homepage from being unpublished ([#2307](#2307)) ([a151d53](a151d53)) * Remove the campaign rendered event ([#2301](#2301)) ([23caa1d](23caa1d)) * Stripe Subscriptions to WC subscriptions migrator ([#2298](#2298)) ([6904356](6904356)), closes [#2251](#2251) * **wc:** force allowing subscription switching ([#2305](#2305)) ([c13e741](c13e741))

adekbadek added 9 commits January 23, 2023 16:58

refactor: WC connection

6024173

chore: add get_donation_name_by_frequency method

b8681da

feat: WCS-first donations processing

6fc5a6d

- create a source on payment, for future charges made by WCS - create an order on processing donation - update the order on webhook callback (when the charge happens)

feat: don't always attach a payment method

a7b7654

PMs are only needed for Stripe Subscriptions.

feat: use provided stripe source instead of payment methods

01acfc3

WC Stripe Gateway uses sources, not payment methods.

feat: smaller config payload

dbfb366

feat: attribute subscription by email if lacking user ID

42a3045

test: fix

3664f1c

feat: check if Stripe CC is the only payment method set in WC

b419c14

adekbadek added [Status] Needs Review The issue or pull request needs to be reviewed Reader Revenue Stripe WooCommerce labels Jan 26, 2023

adekbadek requested a review from a team as a code owner January 26, 2023 11:59

This was referenced Jan 26, 2023

Feat/donate native wc subs Automattic/newspack-blocks#1359

Merged

WCS & Stripe: add payment metadata and update renewal description #2254

Merged

dkoo reviewed Jan 30, 2023

View reviewed changes

includes/reader-revenue/stripe/class-stripe-connection.php Outdated Show resolved Hide resolved

adekbadek added 2 commits February 1, 2023 11:49

fix: WC order item processing

2621c96

feat: sync ESP contact after donation when using WC-first strategy

be22c5f

feat: ease the conditions on using WC-first strategy

aa1bc09

adekbadek requested a review from dkoo February 1, 2023 13:21

Merge master into feat/sdb-native-wc-subs

173121e

adekbadek commented Feb 1, 2023

View reviewed changes

includes/reader-revenue/class-woocommerce-connection.php Show resolved Hide resolved

fix: typo

528fa2f

fix: create WP user for subscriptions

b56ad32

Without RAS enabled, the WP user won't be created on donation.

dkoo approved these changes Feb 3, 2023

View reviewed changes

github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Feb 3, 2023

adekbadek merged commit 009a8a5 into master Feb 13, 2023

adekbadek deleted the feat/sdb-native-wc-subs branch February 13, 2023 10:43

adekbadek added a commit to Automattic/newspack-blocks that referenced this pull request Feb 13, 2023

feat(donate-block): native wc subs (#1359)

9834aa0

See Automattic/newspack-plugin#2251

matticbot added the released on @alpha label Feb 17, 2023

adekbadek mentioned this pull request Feb 21, 2023

Stripe Subscriptions to WC subscriptions migrator #2298

Merged

6 tasks

matticbot added the released on @hotfix/hpb-amp-optimisations label Feb 27, 2023

matticbot added the released label Feb 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stripe: create native WC Subscriptions (if a flag is set) #2251

Stripe: create native WC Subscriptions (if a flag is set) #2251

adekbadek commented Jan 26, 2023 •

edited

Loading

dkoo left a comment

adekbadek commented Feb 1, 2023

dkoo commented Feb 1, 2023 •

edited

Loading

dkoo commented Feb 1, 2023

adekbadek commented Feb 2, 2023

dkoo left a comment

matticbot commented Feb 17, 2023

matticbot commented Feb 17, 2023

matticbot commented Feb 20, 2023

matticbot commented Feb 27, 2023

matticbot commented Feb 28, 2023

Stripe: create native WC Subscriptions (if a flag is set) #2251

Stripe: create native WC Subscriptions (if a flag is set) #2251

Conversation

adekbadek commented Jan 26, 2023 • edited Loading

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

dkoo left a comment

Choose a reason for hiding this comment

adekbadek commented Feb 1, 2023

dkoo commented Feb 1, 2023 • edited Loading

dkoo commented Feb 1, 2023

adekbadek commented Feb 2, 2023

dkoo left a comment

Choose a reason for hiding this comment

matticbot commented Feb 17, 2023

matticbot commented Feb 17, 2023

matticbot commented Feb 20, 2023

matticbot commented Feb 27, 2023

matticbot commented Feb 28, 2023

adekbadek commented Jan 26, 2023 •

edited

Loading

dkoo commented Feb 1, 2023 •

edited

Loading