Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prevent homepage from being unpublished #2307

Merged
merged 1 commit into from
Mar 1, 2023
Merged

feat: prevent homepage from being unpublished #2307

merged 1 commit into from
Mar 1, 2023

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Feb 28, 2023 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Adds a pre_post_update hook to prevent a published homepage from being accidentally unpublished.

How to test the changes in this Pull Request:

  1. Before checking out this branch, unpublish your homepage. This is so we can test that draft homepages can still be updated and published for pre-launch sites.
  2. Check out this branch. Confirm that you can still save changes to the draft version of the homepage and that you can publish the page as usual.
  3. After the page has been published, attempt to unpublish it by changing its status back to draft or by scheduling it to a future date. Confirm that the action fails with an error message:

Screen Shot 2023-02-28 at 3 01 06 PM

  1. Confirm that you can still make changes to the published homepage that do not result in a change in publish status, e.g. updating some content, adding/deleting featured images, etc.
  2. Confirm that other posts and pages are not affected when unpublishing. Also try setting the static homepage to another page in Settings > Readings and/or setting it "to your latest posts", and confirm that you can once again unpublish your test page once it's no longer assigned as the front page.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added [Type] Feature request Request for new features [Status] Needs Review The issue or pull request needs to be reviewed labels Feb 28, 2023
@dkoo dkoo self-assigned this Feb 28, 2023
@dkoo dkoo requested a review from a team as a code owner February 28, 2023 22:02
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 1, 2023
@dkoo dkoo merged commit a151d53 into master Mar 1, 2023
@dkoo dkoo deleted the feat/prevent-homepage-unpublish branch March 1, 2023 16:02
matticbot pushed a commit that referenced this pull request Mar 3, 2023
@semantic-release-bot
chore(release): 1.106.0-alpha.1 [skip ci]
a554a5a 
# [1.106.0-alpha.1](v1.105.0...v1.106.0-alpha.1) (2023-03-03)

### Bug Fixes

* **ads:** gam api availability according to error type ([#2289](#2289)) ([024fe08](024fe08))

### Features

* add a Add new button to subscription lists ([#2314](#2314)) ([9543ad2](9543ad2))
* add ga4 user registered handler ([#2281](#2281)) ([5eb2336](5eb2336))
* add pid to Logger ([#2290](#2290)) ([fd3011c](fd3011c))
* Add popup info to donations ([#2300](#2300)) ([7ea800b](7ea800b))
* allow external links in dashboard via a filter ([#2279](#2279)) ([3943b1a](3943b1a))
* campaigns listeners for the data events api ([#2291](#2291)) ([ab407d4](ab407d4))
* disable save button for unchanged settings ([#2259](#2259)) ([e06d72f](e06d72f)), closes [#1531](#1531)
* **donate-block:** support modal checkout ([#2256](#2256)) ([34226dd](34226dd))
* Normalize donation events ([#2299](#2299)) ([2624d53](2624d53))
* **perfmatters:** improve config ([267306e](267306e))
* prevent homepage from being unpublished ([#2307](#2307)) ([a151d53](a151d53))
* Remove the campaign rendered event ([#2301](#2301)) ([23caa1d](23caa1d))
* Stripe Subscriptions to WC subscriptions migrator ([#2298](#2298)) ([6904356](6904356)), closes [#2251](#2251)
* **wc:** force allowing subscription switching ([#2305](#2305)) ([c13e741](c13e741))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.106.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Mar 14, 2023
@semantic-release-bot
chore(release): 1.106.0 [skip ci]
00f9fc5 
# [1.106.0](v1.105.1...v1.106.0) (2023-03-14)

### Bug Fixes

* **ads:** gam api availability according to error type ([#2289](#2289)) ([024fe08](024fe08))
* show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([1173b5b](1173b5b))

### Features

* add a Add new button to subscription lists ([#2314](#2314)) ([9543ad2](9543ad2))
* add ga4 user registered handler ([#2281](#2281)) ([5eb2336](5eb2336))
* add pid to Logger ([#2290](#2290)) ([fd3011c](fd3011c))
* Add popup info to donations ([#2300](#2300)) ([7ea800b](7ea800b))
* allow external links in dashboard via a filter ([#2279](#2279)) ([3943b1a](3943b1a))
* campaigns listeners for the data events api ([#2291](#2291)) ([ab407d4](ab407d4))
* disable save button for unchanged settings ([#2259](#2259)) ([e06d72f](e06d72f)), closes [#1531](#1531)
* **donate-block:** support modal checkout ([#2256](#2256)) ([34226dd](34226dd))
* Normalize donation events ([#2299](#2299)) ([2624d53](2624d53))
* **perfmatters:** improve config ([267306e](267306e))
* prevent homepage from being unpublished ([#2307](#2307)) ([a151d53](a151d53))
* Remove the campaign rendered event ([#2301](#2301)) ([23caa1d](23caa1d))
* Stripe Subscriptions to WC subscriptions migrator ([#2298](#2298)) ([6904356](6904356)), closes [#2251](#2251)
* **wc:** force allowing subscription switching ([#2305](#2305)) ([c13e741](c13e741))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.106.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gamebits gamebits mentioned this pull request Jun 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

Assignees

@dkoo dkoo

Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge [Type] Feature request Request for new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkoo @matticbot @adekbadek