feat(wc): force allowing subscription switching #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adekbadek
added
[Status] Needs Review
leogermani
reviewed
Feb 27, 2023
| * @param bool $can_switch Whether the subscription amount can be switched. | ||
| */ | ||
| public static function force_allow_switching_subscription_amount( $can_switch ) { | ||
| if ( defined( 'NEWSPACK_PREVENT_FORCE_ALLOW_SWITCHING' ) && NEWSPACK_PREVENT_FORCE_ALLOW_SWITCHING ) { |
There was a problem hiding this comment.
The name of the constant is very confusing to me. Is it
- preventing the site from allowing switch?
- Forcing the site to allow the switch?
- Forcing the site to prevent allowing the switch?
- Preventing the site from being forced to allow the switch?
:)
There was a problem hiding this comment.
That's right :D WDYT about NEWSPACK_PREVENT_WC_SUBS_ALLOW_SWITCHING_OVERRIDE?
leogermani
approved these changes
Feb 27, 2023
github-actions
bot
added
[Status] Approved
Co-authored-by: leogermani <leogermani@automattic.com>
matticbot
pushed a commit
that referenced
this pull request
Mar 3, 2023
# [1.106.0-alpha.1](v1.105.0...v1.106.0-alpha.1) (2023-03-03) ### Bug Fixes * **ads:** gam api availability according to error type ([#2289](#2289)) ([024fe08](024fe08)) ### Features * add a Add new button to subscription lists ([#2314](#2314)) ([9543ad2](9543ad2)) * add ga4 user registered handler ([#2281](#2281)) ([5eb2336](5eb2336)) * add pid to Logger ([#2290](#2290)) ([fd3011c](fd3011c)) * Add popup info to donations ([#2300](#2300)) ([7ea800b](7ea800b)) * allow external links in dashboard via a filter ([#2279](#2279)) ([3943b1a](3943b1a)) * campaigns listeners for the data events api ([#2291](#2291)) ([ab407d4](ab407d4)) * disable save button for unchanged settings ([#2259](#2259)) ([e06d72f](e06d72f)), closes [#1531](#1531) * **donate-block:** support modal checkout ([#2256](#2256)) ([34226dd](34226dd)) * Normalize donation events ([#2299](#2299)) ([2624d53](2624d53)) * **perfmatters:** improve config ([267306e](267306e)) * prevent homepage from being unpublished ([#2307](#2307)) ([a151d53](a151d53)) * Remove the campaign rendered event ([#2301](#2301)) ([23caa1d](23caa1d)) * Stripe Subscriptions to WC subscriptions migrator ([#2298](#2298)) ([6904356](6904356)), closes [#2251](#2251) * **wc:** force allowing subscription switching ([#2305](#2305)) ([c13e741](c13e741))
|
🎉 This PR is included in version 1.106.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Mar 14, 2023
# [1.106.0](v1.105.1...v1.106.0) (2023-03-14) ### Bug Fixes * **ads:** gam api availability according to error type ([#2289](#2289)) ([024fe08](024fe08)) * show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([1173b5b](1173b5b)) ### Features * add a Add new button to subscription lists ([#2314](#2314)) ([9543ad2](9543ad2)) * add ga4 user registered handler ([#2281](#2281)) ([5eb2336](5eb2336)) * add pid to Logger ([#2290](#2290)) ([fd3011c](fd3011c)) * Add popup info to donations ([#2300](#2300)) ([7ea800b](7ea800b)) * allow external links in dashboard via a filter ([#2279](#2279)) ([3943b1a](3943b1a)) * campaigns listeners for the data events api ([#2291](#2291)) ([ab407d4](ab407d4)) * disable save button for unchanged settings ([#2259](#2259)) ([e06d72f](e06d72f)), closes [#1531](#1531) * **donate-block:** support modal checkout ([#2256](#2256)) ([34226dd](34226dd)) * Normalize donation events ([#2299](#2299)) ([2624d53](2624d53)) * **perfmatters:** improve config ([267306e](267306e)) * prevent homepage from being unpublished ([#2307](#2307)) ([a151d53](a151d53)) * Remove the campaign rendered event ([#2301](#2301)) ([23caa1d](23caa1d)) * Stripe Subscriptions to WC subscriptions migrator ([#2298](#2298)) ([6904356](6904356)), closes [#2251](#2251) * **wc:** force allowing subscription switching ([#2305](#2305)) ([c13e741](c13e741))
|
🎉 This PR is included in version 1.106.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
With this change, donors will always be able to switch subscription amounts, unless the
NEWSPACK_PREVENT_FORCE_ALLOW_SWITCHINGenv. flag is set.See 1203981098043663-as-1204007355707594
How to test the changes in this Pull Request:
master,woocommerce_subscriptions_allow_switching_nyp_priceoption from the DB, if present/my-account, and observe that in "My Subscriptions" -> "Subscription totals" table there is no "Change price" buttonNEWSPACK_PREVENT_FORCE_ALLOW_SWITCHINGenv. flag to the site, reload the page, observe the button is gone nowOther information: