fix: show handoff to finish Newspack setup only if setup is incomplete #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoo
added
[Status] Needs Review
leogermani
approved these changes
Mar 13, 2023
github-actions
bot
added
[Status] Approved
dkoo
added a commit
that referenced
this pull request
Mar 13, 2023
matticbot
pushed a commit
that referenced
this pull request
Mar 13, 2023
# [1.106.0-alpha.3](v1.106.0-alpha.2...v1.106.0-alpha.3) (2023-03-13) ### Bug Fixes * show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([1173b5b](1173b5b))
matticbot
pushed a commit
that referenced
this pull request
Mar 14, 2023
# [1.106.0](v1.105.1...v1.106.0) (2023-03-14) ### Bug Fixes * **ads:** gam api availability according to error type ([#2289](#2289)) ([024fe08](024fe08)) * show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([1173b5b](1173b5b)) ### Features * add a Add new button to subscription lists ([#2314](#2314)) ([9543ad2](9543ad2)) * add ga4 user registered handler ([#2281](#2281)) ([5eb2336](5eb2336)) * add pid to Logger ([#2290](#2290)) ([fd3011c](fd3011c)) * Add popup info to donations ([#2300](#2300)) ([7ea800b](7ea800b)) * allow external links in dashboard via a filter ([#2279](#2279)) ([3943b1a](3943b1a)) * campaigns listeners for the data events api ([#2291](#2291)) ([ab407d4](ab407d4)) * disable save button for unchanged settings ([#2259](#2259)) ([e06d72f](e06d72f)), closes [#1531](#1531) * **donate-block:** support modal checkout ([#2256](#2256)) ([34226dd](34226dd)) * Normalize donation events ([#2299](#2299)) ([2624d53](2624d53)) * **perfmatters:** improve config ([267306e](267306e)) * prevent homepage from being unpublished ([#2307](#2307)) ([a151d53](a151d53)) * Remove the campaign rendered event ([#2301](#2301)) ([23caa1d](23caa1d)) * Stripe Subscriptions to WC subscriptions migrator ([#2298](#2298)) ([6904356](6904356)), closes [#2251](#2251) * **wc:** force allowing subscription switching ([#2305](#2305)) ([c13e741](c13e741))
matticbot
pushed a commit
that referenced
this pull request
Mar 16, 2023
# [1.108.0-alpha.1](v1.107.1...v1.108.0-alpha.1) (2023-03-16) ### Bug Fixes * **ads:** proper usage of useEffect cleanup function ([#2335](#2335)) ([58e4c10](58e4c10)) * **cli:** setup config path ([6de5d36](6de5d36)) * **data-events:** mailchimp metadata keys ([#2331](#2331)) ([de82e06](de82e06)) * **modal-checkout:** provide conversion URL for ESP ([feca20d](feca20d)) * only show perfmatters notice if defaults are used ([bdae0b2](bdae0b2)) * post-release merge conflict ([3d03cd2](3d03cd2)) * show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([b0a85ef](b0a85ef)) * toggling settings section ([#2349](#2349)) ([87d5218](87d5218)) * **webhooks:** endpoint requests modal label ([#2332](#2332)) ([fd99ff2](fd99ff2)) * **webhooks:** grid layout ([4aa898f](4aa898f)) * **wizards:** broken rendering in WP 6.2 ([a6cef5a](a6cef5a)) ### Features * add GA4 donation events ([#2326](#2326)) ([a1377a2](a1377a2)) * Add GA4 Newsletters subscriptions events ([#2330](#2330)) ([86ffc66](86ffc66)) * Add popups donation events ([#2310](#2310)) ([53e0c4a](53e0c4a)) * **amp-deprecation:** polyfills for amp-img, amp-iframe, amp-fit-text, amp-youtube ([#2308](#2308)) ([7419cd5](7419cd5)) * **health-check:** mark some plugins as supported ([#2329](#2329)) ([c1774e3](c1774e3))
|
🎉 This PR is included in version 1.108.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Mar 20, 2023
# [1.109.0-alpha.1](v1.108.0...v1.109.0-alpha.1) (2023-03-20) ### Bug Fixes * **ads:** proper usage of useEffect cleanup function ([#2335](#2335)) ([58e4c10](58e4c10)) * **cli:** setup config path ([6de5d36](6de5d36)) * **data-events:** mailchimp metadata keys ([#2331](#2331)) ([de82e06](de82e06)) * **modal-checkout:** provide conversion URL for ESP ([feca20d](feca20d)) * only show perfmatters notice if defaults are used ([bdae0b2](bdae0b2)) * post-release merge conflict ([3d03cd2](3d03cd2)) * show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([b0a85ef](b0a85ef)) * toggling settings section ([#2349](#2349)) ([87d5218](87d5218)) * **webhooks:** endpoint requests modal label ([#2332](#2332)) ([fd99ff2](fd99ff2)) * **webhooks:** grid layout ([4aa898f](4aa898f)) * **wizards:** broken rendering in WP 6.2 ([a6cef5a](a6cef5a)) ### Features * add GA4 donation events ([#2326](#2326)) ([a1377a2](a1377a2)) * Add GA4 Newsletters subscriptions events ([#2330](#2330)) ([86ffc66](86ffc66)) * Add popups donation events ([#2310](#2310)) ([53e0c4a](53e0c4a)) * **amp-deprecation:** polyfills for amp-img, amp-iframe, amp-fit-text, amp-youtube ([#2308](#2308)) ([7419cd5](7419cd5)) * **health-check:** mark some plugins as supported ([#2329](#2329)) ([c1774e3](c1774e3))
|
🎉 This PR is included in version 1.109.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Mar 24, 2023
# [1.110.0-alpha.1](v1.109.0...v1.110.0-alpha.1) (2023-03-24) ### Bug Fixes * **ads:** proper usage of useEffect cleanup function ([#2335](#2335)) ([58e4c10](58e4c10)) * **cli:** setup config path ([6de5d36](6de5d36)) * **data-events:** mailchimp metadata keys ([#2331](#2331)) ([de82e06](de82e06)) * **modal-checkout:** provide conversion URL for ESP ([feca20d](feca20d)) * only show perfmatters notice if defaults are used ([bdae0b2](bdae0b2)) * **perfmatters:** add twitter.com to JS delay list ([34bac52](34bac52)) * post-release merge conflict ([3d03cd2](3d03cd2)) * show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([b0a85ef](b0a85ef)) * toggling settings section ([#2349](#2349)) ([87d5218](87d5218)) * **webhooks:** endpoint requests modal label ([#2332](#2332)) ([fd99ff2](fd99ff2)) * **webhooks:** grid layout ([4aa898f](4aa898f)) * **wizards:** broken rendering in WP 6.2 ([a6cef5a](a6cef5a)) ### Features * add GA4 donation events ([#2326](#2326)) ([a1377a2](a1377a2)) * Add GA4 Newsletters subscriptions events ([#2330](#2330)) ([86ffc66](86ffc66)) * Add popup events to GA4 ([#2337](#2337)) ([62c738e](62c738e)) * Add popups donation events ([#2310](#2310)) ([53e0c4a](53e0c4a)) * **amp-deprecation:** polyfills for amp-img, amp-iframe, amp-fit-text, amp-youtube ([#2308](#2308)) ([7419cd5](7419cd5)) * **health-check:** mark some plugins as supported ([#2329](#2329)) ([c1774e3](c1774e3))
|
🎉 This PR is included in version 1.110.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Mar 27, 2023
# [1.110.0](v1.109.0...v1.110.0) (2023-03-27) ### Bug Fixes * **ads:** proper usage of useEffect cleanup function ([#2335](#2335)) ([58e4c10](58e4c10)) * **cli:** setup config path ([6de5d36](6de5d36)) * **data-events:** mailchimp metadata keys ([#2331](#2331)) ([de82e06](de82e06)) * **modal-checkout:** provide conversion URL for ESP ([feca20d](feca20d)) * only show perfmatters notice if defaults are used ([bdae0b2](bdae0b2)) * **perfmatters:** add twitter.com to JS delay list ([34bac52](34bac52)) * post-release merge conflict ([3d03cd2](3d03cd2)) * show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([b0a85ef](b0a85ef)) * toggling settings section ([#2349](#2349)) ([87d5218](87d5218)) * **webhooks:** endpoint requests modal label ([#2332](#2332)) ([fd99ff2](fd99ff2)) * **webhooks:** grid layout ([4aa898f](4aa898f)) * **wizards:** broken rendering in WP 6.2 ([a6cef5a](a6cef5a)) ### Features * add GA4 donation events ([#2326](#2326)) ([a1377a2](a1377a2)) * Add GA4 Newsletters subscriptions events ([#2330](#2330)) ([86ffc66](86ffc66)) * Add popup events to GA4 ([#2337](#2337)) ([62c738e](62c738e)) * Add popups donation events ([#2310](#2310)) ([53e0c4a](53e0c4a)) * **amp-deprecation:** polyfills for amp-img, amp-iframe, amp-fit-text, amp-youtube ([#2308](#2308)) ([7419cd5](7419cd5)) * **health-check:** mark some plugins as supported ([#2329](#2329)) ([c1774e3](c1774e3))
|
🎉 This PR is included in version 1.110.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Prevents the handoff banner to complete Newspack setup from being displayed in WP admin if Newspack setup has already been completed. Note that this doesn't fix a related issue in which the handoff banner causes non-block-editor admin pages to be unscrollable.
Closes
1204068745367915/1204165700596247.How to test the changes in this Pull Request:
master, on a site that's already been setup with Newspack, force the handoff banner to be displayed by setting an option via WP CLI:wp option set newspack_handoff 1Other information: