fix(ads): proper usage of useEffect cleanup function #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelpeixe
added
the
[Status] Needs Review
adekbadek
approved these changes
Mar 14, 2023
github-actions
bot
added
[Status] Approved
6 tasks
matticbot
pushed a commit
that referenced
this pull request
Mar 16, 2023
# [1.108.0-alpha.1](v1.107.1...v1.108.0-alpha.1) (2023-03-16) ### Bug Fixes * **ads:** proper usage of useEffect cleanup function ([#2335](#2335)) ([58e4c10](58e4c10)) * **cli:** setup config path ([6de5d36](6de5d36)) * **data-events:** mailchimp metadata keys ([#2331](#2331)) ([de82e06](de82e06)) * **modal-checkout:** provide conversion URL for ESP ([feca20d](feca20d)) * only show perfmatters notice if defaults are used ([bdae0b2](bdae0b2)) * post-release merge conflict ([3d03cd2](3d03cd2)) * show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([b0a85ef](b0a85ef)) * toggling settings section ([#2349](#2349)) ([87d5218](87d5218)) * **webhooks:** endpoint requests modal label ([#2332](#2332)) ([fd99ff2](fd99ff2)) * **webhooks:** grid layout ([4aa898f](4aa898f)) * **wizards:** broken rendering in WP 6.2 ([a6cef5a](a6cef5a)) ### Features * add GA4 donation events ([#2326](#2326)) ([a1377a2](a1377a2)) * Add GA4 Newsletters subscriptions events ([#2330](#2330)) ([86ffc66](86ffc66)) * Add popups donation events ([#2310](#2310)) ([53e0c4a](53e0c4a)) * **amp-deprecation:** polyfills for amp-img, amp-iframe, amp-fit-text, amp-youtube ([#2308](#2308)) ([7419cd5](7419cd5)) * **health-check:** mark some plugins as supported ([#2329](#2329)) ([c1774e3](c1774e3))
|
🎉 This PR is included in version 1.108.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Mar 20, 2023
# [1.109.0-alpha.1](v1.108.0...v1.109.0-alpha.1) (2023-03-20) ### Bug Fixes * **ads:** proper usage of useEffect cleanup function ([#2335](#2335)) ([58e4c10](58e4c10)) * **cli:** setup config path ([6de5d36](6de5d36)) * **data-events:** mailchimp metadata keys ([#2331](#2331)) ([de82e06](de82e06)) * **modal-checkout:** provide conversion URL for ESP ([feca20d](feca20d)) * only show perfmatters notice if defaults are used ([bdae0b2](bdae0b2)) * post-release merge conflict ([3d03cd2](3d03cd2)) * show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([b0a85ef](b0a85ef)) * toggling settings section ([#2349](#2349)) ([87d5218](87d5218)) * **webhooks:** endpoint requests modal label ([#2332](#2332)) ([fd99ff2](fd99ff2)) * **webhooks:** grid layout ([4aa898f](4aa898f)) * **wizards:** broken rendering in WP 6.2 ([a6cef5a](a6cef5a)) ### Features * add GA4 donation events ([#2326](#2326)) ([a1377a2](a1377a2)) * Add GA4 Newsletters subscriptions events ([#2330](#2330)) ([86ffc66](86ffc66)) * Add popups donation events ([#2310](#2310)) ([53e0c4a](53e0c4a)) * **amp-deprecation:** polyfills for amp-img, amp-iframe, amp-fit-text, amp-youtube ([#2308](#2308)) ([7419cd5](7419cd5)) * **health-check:** mark some plugins as supported ([#2329](#2329)) ([c1774e3](c1774e3))
|
🎉 This PR is included in version 1.109.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Mar 24, 2023
# [1.110.0-alpha.1](v1.109.0...v1.110.0-alpha.1) (2023-03-24) ### Bug Fixes * **ads:** proper usage of useEffect cleanup function ([#2335](#2335)) ([58e4c10](58e4c10)) * **cli:** setup config path ([6de5d36](6de5d36)) * **data-events:** mailchimp metadata keys ([#2331](#2331)) ([de82e06](de82e06)) * **modal-checkout:** provide conversion URL for ESP ([feca20d](feca20d)) * only show perfmatters notice if defaults are used ([bdae0b2](bdae0b2)) * **perfmatters:** add twitter.com to JS delay list ([34bac52](34bac52)) * post-release merge conflict ([3d03cd2](3d03cd2)) * show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([b0a85ef](b0a85ef)) * toggling settings section ([#2349](#2349)) ([87d5218](87d5218)) * **webhooks:** endpoint requests modal label ([#2332](#2332)) ([fd99ff2](fd99ff2)) * **webhooks:** grid layout ([4aa898f](4aa898f)) * **wizards:** broken rendering in WP 6.2 ([a6cef5a](a6cef5a)) ### Features * add GA4 donation events ([#2326](#2326)) ([a1377a2](a1377a2)) * Add GA4 Newsletters subscriptions events ([#2330](#2330)) ([86ffc66](86ffc66)) * Add popup events to GA4 ([#2337](#2337)) ([62c738e](62c738e)) * Add popups donation events ([#2310](#2310)) ([53e0c4a](53e0c4a)) * **amp-deprecation:** polyfills for amp-img, amp-iframe, amp-fit-text, amp-youtube ([#2308](#2308)) ([7419cd5](7419cd5)) * **health-check:** mark some plugins as supported ([#2329](#2329)) ([c1774e3](c1774e3))
|
🎉 This PR is included in version 1.110.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Mar 27, 2023
# [1.110.0](v1.109.0...v1.110.0) (2023-03-27) ### Bug Fixes * **ads:** proper usage of useEffect cleanup function ([#2335](#2335)) ([58e4c10](58e4c10)) * **cli:** setup config path ([6de5d36](6de5d36)) * **data-events:** mailchimp metadata keys ([#2331](#2331)) ([de82e06](de82e06)) * **modal-checkout:** provide conversion URL for ESP ([feca20d](feca20d)) * only show perfmatters notice if defaults are used ([bdae0b2](bdae0b2)) * **perfmatters:** add twitter.com to JS delay list ([34bac52](34bac52)) * post-release merge conflict ([3d03cd2](3d03cd2)) * show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([b0a85ef](b0a85ef)) * toggling settings section ([#2349](#2349)) ([87d5218](87d5218)) * **webhooks:** endpoint requests modal label ([#2332](#2332)) ([fd99ff2](fd99ff2)) * **webhooks:** grid layout ([4aa898f](4aa898f)) * **wizards:** broken rendering in WP 6.2 ([a6cef5a](a6cef5a)) ### Features * add GA4 donation events ([#2326](#2326)) ([a1377a2](a1377a2)) * Add GA4 Newsletters subscriptions events ([#2330](#2330)) ([86ffc66](86ffc66)) * Add popup events to GA4 ([#2337](#2337)) ([62c738e](62c738e)) * Add popups donation events ([#2310](#2310)) ([53e0c4a](53e0c4a)) * **amp-deprecation:** polyfills for amp-img, amp-iframe, amp-fit-text, amp-youtube ([#2308](#2308)) ([7419cd5](7419cd5)) * **health-check:** mark some plugins as supported ([#2329](#2329)) ([c1774e3](c1774e3))
|
🎉 This PR is included in version 1.110.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR fixes an incorrect usage of the
useEffecthook in some instances of the Advertising wizard. The return of the hook must be eitherundefinedor a valid cleanup function.Related #2269
How to test the changes in this Pull Request:
No changes should be visible on the latest stable version of WP (6.1.1):
Other information: