Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webhooks): endpoint requests modal label #2332

Merged
merged 1 commit into from
Mar 9, 2023
Merged

fix(webhooks): endpoint requests modal label #2332

merged 1 commit into from
Mar 9, 2023

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Fixes the label of the endpoint name while viewing its requests modal.

How to test the changes in this Pull Request:

  1. Make sure you have define( 'NEWSPACK_EXPERIMENTAL_WEBHOOKS', true );
  2. While in the master branch, visit the Newspack -> Connections page and set up an endpoint with a Label if you haven't already
  3. Click on the 3 dots menu and click "View requests"
  4. Confirm the [object Object] in the text
  5. Check out this branch and confirm the text has a proper label for the endpoint
  6. Edit the endpoint, leave Label blank and save
  7. View the requests and confirm the label is replaced with the shortened URL

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Mar 8, 2023
@miguelpeixe miguelpeixe requested a review from a team as a code owner March 8, 2023 13:07
@miguelpeixe miguelpeixe self-assigned this Mar 8, 2023
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 9, 2023
@miguelpeixe miguelpeixe merged commit fd99ff2 into master Mar 9, 2023
@miguelpeixe miguelpeixe deleted the fix/webhooks-endpoint-requests-label branch March 9, 2023 12:37
matticbot pushed a commit that referenced this pull request Mar 16, 2023
@semantic-release-bot
chore(release): 1.108.0-alpha.1 [skip ci]
a592405 
# [1.108.0-alpha.1](v1.107.1...v1.108.0-alpha.1) (2023-03-16)

### Bug Fixes

* **ads:** proper usage of useEffect cleanup function ([#2335](#2335)) ([58e4c10](58e4c10))
* **cli:** setup config path ([6de5d36](6de5d36))
* **data-events:** mailchimp metadata keys ([#2331](#2331)) ([de82e06](de82e06))
* **modal-checkout:** provide conversion URL for ESP ([feca20d](feca20d))
* only show perfmatters notice if defaults are used ([bdae0b2](bdae0b2))
* post-release merge conflict ([3d03cd2](3d03cd2))
* show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([b0a85ef](b0a85ef))
* toggling settings section ([#2349](#2349)) ([87d5218](87d5218))
* **webhooks:** endpoint requests modal label ([#2332](#2332)) ([fd99ff2](fd99ff2))
* **webhooks:** grid layout ([4aa898f](4aa898f))
* **wizards:** broken rendering in WP 6.2 ([a6cef5a](a6cef5a))

### Features

* add GA4 donation events ([#2326](#2326)) ([a1377a2](a1377a2))
* Add GA4 Newsletters subscriptions events ([#2330](#2330)) ([86ffc66](86ffc66))
* Add popups donation events ([#2310](#2310)) ([53e0c4a](53e0c4a))
* **amp-deprecation:** polyfills for amp-img, amp-iframe, amp-fit-text, amp-youtube ([#2308](#2308)) ([7419cd5](7419cd5))
* **health-check:** mark some plugins as supported ([#2329](#2329)) ([c1774e3](c1774e3))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.108.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Mar 20, 2023
@semantic-release-bot
chore(release): 1.109.0-alpha.1 [skip ci]
5ac8892 
# [1.109.0-alpha.1](v1.108.0...v1.109.0-alpha.1) (2023-03-20)

### Bug Fixes

* **ads:** proper usage of useEffect cleanup function ([#2335](#2335)) ([58e4c10](58e4c10))
* **cli:** setup config path ([6de5d36](6de5d36))
* **data-events:** mailchimp metadata keys ([#2331](#2331)) ([de82e06](de82e06))
* **modal-checkout:** provide conversion URL for ESP ([feca20d](feca20d))
* only show perfmatters notice if defaults are used ([bdae0b2](bdae0b2))
* post-release merge conflict ([3d03cd2](3d03cd2))
* show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([b0a85ef](b0a85ef))
* toggling settings section ([#2349](#2349)) ([87d5218](87d5218))
* **webhooks:** endpoint requests modal label ([#2332](#2332)) ([fd99ff2](fd99ff2))
* **webhooks:** grid layout ([4aa898f](4aa898f))
* **wizards:** broken rendering in WP 6.2 ([a6cef5a](a6cef5a))

### Features

* add GA4 donation events ([#2326](#2326)) ([a1377a2](a1377a2))
* Add GA4 Newsletters subscriptions events ([#2330](#2330)) ([86ffc66](86ffc66))
* Add popups donation events ([#2310](#2310)) ([53e0c4a](53e0c4a))
* **amp-deprecation:** polyfills for amp-img, amp-iframe, amp-fit-text, amp-youtube ([#2308](#2308)) ([7419cd5](7419cd5))
* **health-check:** mark some plugins as supported ([#2329](#2329)) ([c1774e3](c1774e3))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.109.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Mar 24, 2023
@semantic-release-bot
chore(release): 1.110.0-alpha.1 [skip ci]
27c7d6f 
# [1.110.0-alpha.1](v1.109.0...v1.110.0-alpha.1) (2023-03-24)

### Bug Fixes

* **ads:** proper usage of useEffect cleanup function ([#2335](#2335)) ([58e4c10](58e4c10))
* **cli:** setup config path ([6de5d36](6de5d36))
* **data-events:** mailchimp metadata keys ([#2331](#2331)) ([de82e06](de82e06))
* **modal-checkout:** provide conversion URL for ESP ([feca20d](feca20d))
* only show perfmatters notice if defaults are used ([bdae0b2](bdae0b2))
* **perfmatters:** add twitter.com to JS delay list ([34bac52](34bac52))
* post-release merge conflict ([3d03cd2](3d03cd2))
* show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([b0a85ef](b0a85ef))
* toggling settings section ([#2349](#2349)) ([87d5218](87d5218))
* **webhooks:** endpoint requests modal label ([#2332](#2332)) ([fd99ff2](fd99ff2))
* **webhooks:** grid layout ([4aa898f](4aa898f))
* **wizards:** broken rendering in WP 6.2 ([a6cef5a](a6cef5a))

### Features

* add GA4 donation events ([#2326](#2326)) ([a1377a2](a1377a2))
* Add GA4 Newsletters subscriptions events ([#2330](#2330)) ([86ffc66](86ffc66))
* Add popup events to GA4 ([#2337](#2337)) ([62c738e](62c738e))
* Add popups donation events ([#2310](#2310)) ([53e0c4a](53e0c4a))
* **amp-deprecation:** polyfills for amp-img, amp-iframe, amp-fit-text, amp-youtube ([#2308](#2308)) ([7419cd5](7419cd5))
* **health-check:** mark some plugins as supported ([#2329](#2329)) ([c1774e3](c1774e3))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.110.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Mar 27, 2023
@semantic-release-bot
chore(release): 1.110.0 [skip ci]
5868143 
# [1.110.0](v1.109.0...v1.110.0) (2023-03-27)

### Bug Fixes

* **ads:** proper usage of useEffect cleanup function ([#2335](#2335)) ([58e4c10](58e4c10))
* **cli:** setup config path ([6de5d36](6de5d36))
* **data-events:** mailchimp metadata keys ([#2331](#2331)) ([de82e06](de82e06))
* **modal-checkout:** provide conversion URL for ESP ([feca20d](feca20d))
* only show perfmatters notice if defaults are used ([bdae0b2](bdae0b2))
* **perfmatters:** add twitter.com to JS delay list ([34bac52](34bac52))
* post-release merge conflict ([3d03cd2](3d03cd2))
* show handoff to finish Newspack setup only if setup is incomplete ([#2343](#2343)) ([b0a85ef](b0a85ef))
* toggling settings section ([#2349](#2349)) ([87d5218](87d5218))
* **webhooks:** endpoint requests modal label ([#2332](#2332)) ([fd99ff2](fd99ff2))
* **webhooks:** grid layout ([4aa898f](4aa898f))
* **wizards:** broken rendering in WP 6.2 ([a6cef5a](a6cef5a))

### Features

* add GA4 donation events ([#2326](#2326)) ([a1377a2](a1377a2))
* Add GA4 Newsletters subscriptions events ([#2330](#2330)) ([86ffc66](86ffc66))
* Add popup events to GA4 ([#2337](#2337)) ([62c738e](62c738e))
* Add popups donation events ([#2310](#2310)) ([53e0c4a](53e0c4a))
* **amp-deprecation:** polyfills for amp-img, amp-iframe, amp-fit-text, amp-youtube ([#2308](#2308)) ([7419cd5](7419cd5))
* **health-check:** mark some plugins as supported ([#2329](#2329)) ([c1774e3](c1774e3))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.110.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

Assignees

@miguelpeixe miguelpeixe

Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelpeixe @matticbot @adekbadek