fix(ads): remove fixed height setting #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelpeixe
added
the
[Status] Needs Review
adekbadek
approved these changes
Jan 30, 2023
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Feb 17, 2023
# [1.103.0-alpha.2](v1.103.0-alpha.1...v1.103.0-alpha.2) (2023-02-17) ### Bug Fixes * **ads-wizard:** cancelled state of unit displayed on the list ([#2272](#2272)) ([e10b592](e10b592)) * **ads:** remove fixed height setting ([#2255](#2255)) ([0031b89](0031b89)) * change default auth strategy to "link" ([#2261](#2261)) ([c4b2e2c](c4b2e2c)) * update package.json to resolve a merge conflict with master ([f2408a3](f2408a3)) * **webhooks:** check if endpoint exists ([#2276](#2276)) ([5a95e2c](5a95e2c)) ### Features * bootstrap GA4 connector ([#2241](#2241)) ([f7582a4](f7582a4)) * **data-events:** mailchimp connector ([#2233](#2233)) ([08060c6](08060c6)) * **data-events:** standardize the use of "user_id" and "email" ([#2263](#2263)) ([d6b6903](d6b6903)) * **donations:** add payment metadata and update renewal description ([#2254](#2254)) ([b039304](b039304)) * **my-account:** display stripe billing link regardless of RR platform ([df540fe](df540fe)) * **perfmatters:** defaults adjustments, remove feature flag ([#2271](#2271)) ([cf5ad51](cf5ad51)) * **performance:** minify all inline CSS ([#2239](#2239)) ([fbb415f](fbb415f)) * **ras:** enable custom contact metadata prefixes ([#2249](#2249)) ([e9843e4](e9843e4)) * require all woo plugins for RAS ([#2260](#2260)) ([5f6a818](5f6a818)) * **stripe:** create native WC Subscriptions (if feature flag is set) ([#2251](#2251)) ([009a8a5](009a8a5)) * **webhooks:** support label for endpoints ([#2262](#2262)) ([39da7be](39da7be))
|
🎉 This PR is included in version 1.103.0-alpha.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Feb 17, 2023
# [1.104.0-alpha.1](v1.103.0...v1.104.0-alpha.1) (2023-02-17) ### Bug Fixes * **ads-wizard:** cancelled state of unit displayed on the list ([#2272](#2272)) ([e10b592](e10b592)) * **ads:** remove fixed height setting ([#2255](#2255)) ([0031b89](0031b89)) * change default auth strategy to "link" ([#2261](#2261)) ([c4b2e2c](c4b2e2c)) * **webhooks:** check if endpoint exists ([#2276](#2276)) ([5a95e2c](5a95e2c)) ### Features * bootstrap GA4 connector ([#2241](#2241)) ([f7582a4](f7582a4)) * **data-events:** mailchimp connector ([#2233](#2233)) ([08060c6](08060c6)) * **data-events:** standardize the use of "user_id" and "email" ([#2263](#2263)) ([d6b6903](d6b6903)) * **donations:** add payment metadata and update renewal description ([#2254](#2254)) ([b039304](b039304)) * **my-account:** display stripe billing link regardless of RR platform ([df540fe](df540fe)) * **perfmatters:** defaults adjustments, remove feature flag ([#2271](#2271)) ([cf5ad51](cf5ad51)) * **performance:** minify all inline CSS ([#2239](#2239)) ([fbb415f](fbb415f)) * **ras:** enable custom contact metadata prefixes ([#2249](#2249)) ([e9843e4](e9843e4)) * require all woo plugins for RAS ([#2260](#2260)) ([5f6a818](5f6a818)) * **stripe:** create native WC Subscriptions (if feature flag is set) ([#2251](#2251)) ([009a8a5](009a8a5)) * **webhooks:** support label for endpoints ([#2262](#2262)) ([39da7be](39da7be))
|
🎉 This PR is included in version 1.104.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Feb 20, 2023
# [1.105.0-alpha.1](v1.104.0...v1.105.0-alpha.1) (2023-02-20) ### Bug Fixes * **ads-wizard:** cancelled state of unit displayed on the list ([#2272](#2272)) ([e10b592](e10b592)) * **ads:** remove fixed height setting ([#2255](#2255)) ([0031b89](0031b89)) * change default auth strategy to "link" ([#2261](#2261)) ([c4b2e2c](c4b2e2c)) * **webhooks:** check if endpoint exists ([#2276](#2276)) ([5a95e2c](5a95e2c)) ### Features * bootstrap GA4 connector ([#2241](#2241)) ([f7582a4](f7582a4)) * **data-events:** mailchimp connector ([#2233](#2233)) ([08060c6](08060c6)) * **data-events:** standardize the use of "user_id" and "email" ([#2263](#2263)) ([d6b6903](d6b6903)) * **donations:** add payment metadata and update renewal description ([#2254](#2254)) ([b039304](b039304)) * **my-account:** display stripe billing link regardless of RR platform ([df540fe](df540fe)) * **perfmatters:** defaults adjustments, remove feature flag ([#2271](#2271)) ([cf5ad51](cf5ad51)) * **performance:** minify all inline CSS ([#2239](#2239)) ([fbb415f](fbb415f)) * **ras:** enable custom contact metadata prefixes ([#2249](#2249)) ([e9843e4](e9843e4)) * require all woo plugins for RAS ([#2260](#2260)) ([5f6a818](5f6a818)) * **stripe:** create native WC Subscriptions (if feature flag is set) ([#2251](#2251)) ([009a8a5](009a8a5)) * **webhooks:** support label for endpoints ([#2262](#2262)) ([39da7be](39da7be))
|
🎉 This PR is included in version 1.105.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.105.0-hotfix-hpb-amp-optimisations.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Feb 28, 2023
# [1.105.0](v1.104.1...v1.105.0) (2023-02-28) ### Bug Fixes * **ads-wizard:** cancelled state of unit displayed on the list ([#2272](#2272)) ([e10b592](e10b592)) * **ads:** remove fixed height setting ([#2255](#2255)) ([0031b89](0031b89)) * change default auth strategy to "link" ([#2261](#2261)) ([c4b2e2c](c4b2e2c)) * **webhooks:** check if endpoint exists ([#2276](#2276)) ([5a95e2c](5a95e2c)) ### Features * bootstrap GA4 connector ([#2241](#2241)) ([f7582a4](f7582a4)) * **data-events:** mailchimp connector ([#2233](#2233)) ([08060c6](08060c6)) * **data-events:** standardize the use of "user_id" and "email" ([#2263](#2263)) ([d6b6903](d6b6903)) * **donations:** add payment metadata and update renewal description ([#2254](#2254)) ([b039304](b039304)) * **my-account:** display stripe billing link regardless of RR platform ([df540fe](df540fe)) * **perfmatters:** defaults adjustments, remove feature flag ([#2271](#2271)) ([cf5ad51](cf5ad51)) * **performance:** minify all inline CSS ([#2239](#2239)) ([fbb415f](fbb415f)) * **ras:** enable custom contact metadata prefixes ([#2249](#2249)) ([e9843e4](e9843e4)) * require all woo plugins for RAS ([#2260](#2260)) ([5f6a818](5f6a818)) * **stripe:** create native WC Subscriptions (if feature flag is set) ([#2251](#2251)) ([009a8a5](009a8a5)) * **webhooks:** support label for endpoints ([#2262](#2262)) ([39da7be](39da7be))
|
🎉 This PR is included in version 1.105.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Remove the Ads' per-placement setting for fixed height.
Further details and instructions at Automattic/newspack-ads#590
Other information: