Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge RAS-ACC work into trunk #1977

Merged
merged 433 commits into from
Nov 28, 2024
Merged

feat: merge RAS-ACC work into trunk #1977

merged 433 commits into from
Nov 28, 2024

Conversation

laurelfulford
Copy link
Contributor

@laurelfulford laurelfulford commented Nov 27, 2024

All Submissions:

Changes proposed in this Pull Request:

This PR merges the epic/ras-acc work into trunk 🎉

The major changes covered in the Newspack Blocks plugin are related to the modal checkout and checkout button block.

How to test the changes in this Pull Request:

I'm not sure the best way to test this but I think running smoke tests through a few flows with the other related PRs would be best.

  1. Apply this and other PRs related to RAS-ACC (there should be a plugins, newsletters, and theme one)
  2. Smoke test different checkouts with the checkout button block including:
  • Memberships
  • Subscriptions
  • Variations
  1. Smoke test the modal checkout from the donate block.
  2. Check that existing Checkout Button blocks (ones added when on /trunk) don't throw errors in the editor.
  3. Run through anything else you can think of!

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

laurelfulford and others added 30 commits June 6, 2024 13:42
fix(ras-acc): hide NYP on billing screen
fix(ras-acc): add extra check for iframe for spinner visibility
…dths

fix(ras-acc): tweak billing, shipping columns styles
This PR adds the product price summary card to the auth flow
fix(ras-acc): update shipping details header
This PR adjusts nyp price summary styles in variation modal to match other price summary formats
…1754)

This adds a new welcome email template for readers who register via checkout.
fix(ras-acc): don't show phone field when it's not enabled
…1782)

This PR updates the thank you modal title during the modal checkout flow
This PR adjusts the checkout thankyou modal width to use the newspack-ui__modal--small sizing
…1784)

This updates the top and bottom margins of the Ship to a different address? and This purchase is a gift toggle/checkbox.
@laurelfulford
Copy link
Contributor Author

🚀

@laurelfulford laurelfulford merged commit 2eeaa89 into trunk Nov 28, 2024
8 checks passed
@laurelfulford laurelfulford deleted the feat/merge-ras-acc branch November 28, 2024 18:39
Copy link

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Nov 29, 2024
# [4.5.0-alpha.1](v4.4.0...v4.5.0-alpha.1) (2024-11-29)

### Bug Fixes

* also search for coauthor posts by term slug ([#1954](#1954)) ([49357ff](49357ff))
* **ras-acc:** correct spacing issue around saved credit cards ([#1980](#1980)) ([52a5c57](52a5c57))
* **ras-acc:** fix display issues with Additional Fields ([#1979](#1979)) ([b9390ef](b9390ef))
* **ras-acc:** remove space caused by empty divs ([#1978](#1978)) ([8cb6ead](8cb6ead))

### Features

* add Bluesky support to the Author Profile, List blocks ([#1969](#1969)) ([d26a7e4](d26a7e4))
* add support for Newspack Guest Contributor in HPP blocks ([#1934](#1934)) ([c16849e](c16849e))
* merge RAS-ACC work into trunk ([#1977](#1977)) ([2eeaa89](2eeaa89))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.5.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Dec 9, 2024
# [4.5.0](v4.4.0...v4.5.0) (2024-12-09)

### Bug Fixes

* also search for coauthor posts by term slug ([#1954](#1954)) ([49357ff](49357ff))
* **modal-checkout:** allow all gateway assets ([#1988](#1988)) ([e371e30](e371e30))
* **modal-checkout:** handle paypal ([#1985](#1985)) ([9bb2b8c](9bb2b8c))
* **ras-acc:** correct spacing issue around saved credit cards ([#1980](#1980)) ([52a5c57](52a5c57))
* **ras-acc:** fix display issues with Additional Fields ([#1979](#1979)) ([b9390ef](b9390ef))
* **ras-acc:** remove space caused by empty divs ([#1978](#1978)) ([8cb6ead](8cb6ead))
* remove reCaptcha for WooCommere code from modal checkout ([#1984](#1984)) ([8e250eb](8e250eb))

### Features

* add Bluesky support to the Author Profile, List blocks ([#1969](#1969)) ([d26a7e4](d26a7e4))
* add CSS class to variation buttons for tracking ([#1989](#1989)) ([910e6b1](910e6b1))
* add support for Newspack Guest Contributor in HPP blocks ([#1934](#1934)) ([c16849e](c16849e))
* merge RAS-ACC work into trunk ([#1977](#1977)) ([2eeaa89](2eeaa89))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants