Columns styles: Update editor selector for reordering columns #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Jeff! |
jeffersonrabb
pushed a commit
that referenced
this pull request
May 5, 2020
* refactor: alphabetization (#447) * fix: patterns preview thumbnails (#453) * fix: update editor selector for reordering columns (#435) * feat: use swiper for non-amp carousels * chore: remove amp libraries in non-amp requests * feat: use swiper for non-amp carousels * feat: implement all carousel features with swiper * chore: fix phpcs syntax issues * fix: prev/next buttons position * fix: use large featured image in the editor * refactor: data attributes for autoplay and delay Co-authored-by: Thomas Guillot <thomasguillot@users.noreply.github.com> * fix: byline, avatar and date in carousel block (#455) * fix: byline, avatar and date in carousel block * feat: real author links for avatar and author name Co-authored-by: Thomas Guillot <thomasguillot@users.noreply.github.com> Co-authored-by: Laurel <laurel.fulford@automattic.com>
matticbot
pushed a commit
that referenced
this pull request
May 5, 2020
# [1.4.0](v1.3.1...v1.4.0) (2020-05-05) ### Bug Fixes * byline, avatar and date in carousel block ([#455](#455)) ([85b7865](85b7865)) * patterns preview thumbnails ([#453](#453)) ([3ca80e0](3ca80e0)) * update editor selector for reordering columns ([#435](#435)) ([396826a](396826a)) ### Features * use swiper for non-amp carousels ([94c0a2b](94c0a2b))
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR removes the
.wp-blockclass from the selectors for the Columns block styles in the editor. At some point, this container was removed from from the block markup, but! It does exist on the block itself. So when the block is nested in another -- like the group block, like you'd see with the Newspack block patterns -- the preview displays as expected.Closes #434.
How to test the changes in this Pull Request:
npm run buildOther information: