fix: byline, avatar and date in carousel block #455
Conversation
There was a problem hiding this comment.
This works for me as described.
The only issue I ran into was for Co-Authors Plus and the Article Carousel block on the front end -- only one author would show when multiples were assigned. I'm able to recreate this in master too, though, and the multiple authors display as expected in the editor.
I'll spin up a separate issue for the multiple authors on the front-end!
src/shared/js/utils.js
Outdated
| return [ | ||
| ...accumulator, | ||
| <span className="author vcard" key={ author.id }> | ||
| <a className="url fn n" href="#"> |
There was a problem hiding this comment.
Can the anchor be removed? It doesn't look like its functional
There was a problem hiding this comment.
Added support for the actual author links in 4dedb72
src/shared/js/utils.js
Outdated
| export const formatAvatars = authorInfo => | ||
| authorInfo.map( author => ( | ||
| <span className="avatar author-avatar" key={ author.id }> | ||
| <a className="url fn n" href="#"> |
There was a problem hiding this comment.
Can the anchor be removed? It doesn't look like its functional
There was a problem hiding this comment.
Added support for the actual author links in 4dedb72
* refactor: alphabetization (#447) * fix: patterns preview thumbnails (#453) * fix: update editor selector for reordering columns (#435) * feat: use swiper for non-amp carousels * chore: remove amp libraries in non-amp requests * feat: use swiper for non-amp carousels * feat: implement all carousel features with swiper * chore: fix phpcs syntax issues * fix: prev/next buttons position * fix: use large featured image in the editor * refactor: data attributes for autoplay and delay Co-authored-by: Thomas Guillot <thomasguillot@users.noreply.github.com> * fix: byline, avatar and date in carousel block (#455) * fix: byline, avatar and date in carousel block * feat: real author links for avatar and author name Co-authored-by: Thomas Guillot <thomasguillot@users.noreply.github.com> Co-authored-by: Laurel <laurel.fulford@automattic.com>
# [1.4.0](v1.3.1...v1.4.0) (2020-05-05) ### Bug Fixes * byline, avatar and date in carousel block ([#455](#455)) ([85b7865](85b7865)) * patterns preview thumbnails ([#453](#453)) ([3ca80e0](3ca80e0)) * update editor selector for reordering columns ([#435](#435)) ([396826a](396826a)) ### Features * use swiper for non-amp carousels ([94c0a2b](94c0a2b))
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
The byline and avatar display logic in Homepage Posts has changed since Carousel was first introduced. This brings the two in sync, extracting the handling of both to a shared utilities file.
Closes #445
How to test the changes in this Pull Request:
Other information: