fix: currency symbol handling #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelpeixe
requested changes
Sep 1, 2021
There was a problem hiding this comment.
The new rules are being applied only for .tiered donate blocks, they could be replicated to work with the .untiered block, but I believe it makes sense applied to all money-input elements.
|
Good catch, @miguelpeixe ! Fixed in 158147f |
miguelpeixe
requested changes
Sep 2, 2021
There was a problem hiding this comment.
As the linter already accused, there's already a selector for .wpbnbd .money-input that should be prioritized for the new rules.
|
Fixed in 44ac1ed 👌 |
matticbot
pushed a commit
that referenced
this pull request
Sep 7, 2021
# [1.37.0-alpha.1](v1.36.0...v1.37.0-alpha.1) (2021-09-07) ### Bug Fixes * currency symbol handling ([#850](#850)) ([9637d89](9637d89)) * show all saved post types in specific posts field ([#857](#857)) ([42c25a9](42c25a9)) ### Features * make Donate Block 'thank you' text editable ([#854](#854)) ([7e8f1ea](7e8f1ea))
|
🎉 This PR is included in version 1.37.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Sep 8, 2021
# [1.37.0](v1.36.0...v1.37.0) (2021-09-08) ### Bug Fixes * currency symbol handling ([#850](#850)) ([9637d89](9637d89)) * only show category link anchor tags if the category has a link ([#863](#863)) ([549f03a](549f03a)) * show all saved post types in specific posts field ([#857](#857)) ([42c25a9](42c25a9)) ### Features * make Donate Block 'thank you' text editable ([#854](#854)) ([7e8f1ea](7e8f1ea))
|
🎉 This PR is included in version 1.37.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes Automattic/newspack-plugin#235.
How to test the changes in this Pull Request:
master, choose "Uzbekistani som" as the currency in Reader Revenue wizardOther information: