Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show all saved post types in specific posts field #857

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Sep 3, 2021

All Submissions:

Changes proposed in this Pull Request:

Fixes a minor but editorially annoying bug with the Specific Posts selector field for Homepage Posts and Post Carousel blocks, discovered during GDG launch.

How to test the changes in this Pull Request:

  1. On master, add a Homepage Posts and/or Post Carousel block to a post or page.
  2. Under Post Types, choose "Posts" and at least one other post type.
  3. Under Display Settings, turn on Specific Posts and choose some posts (of the actual post post type) as well as posts of post types other than post. Save/update.
  4. Refresh the editor. Select the block and expand Display Settings. Observe that in the Specific Posts field, only titles for saved posts with the post type of post are shown in the field. This means it's not possible to remove the posts of other post types from this block.
  5. Check out this branch, repeat step 4, confirm that saved posts of all post types are now shown.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added the bug Something isn't working label Sep 3, 2021
@dkoo dkoo requested a review from a team September 3, 2021 16:41
@dkoo dkoo self-assigned this Sep 3, 2021
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as described! 💯

@dkoo dkoo merged commit 42c25a9 into master Sep 3, 2021
@dkoo dkoo deleted the fix/specific-posts-cpts branch September 3, 2021 20:40
matticbot pushed a commit that referenced this pull request Sep 7, 2021
# [1.37.0-alpha.1](v1.36.0...v1.37.0-alpha.1) (2021-09-07)

### Bug Fixes

* currency symbol handling ([#850](#850)) ([9637d89](9637d89))
* show all saved post types in specific posts field ([#857](#857)) ([42c25a9](42c25a9))

### Features

* make Donate Block 'thank you' text editable ([#854](#854)) ([7e8f1ea](7e8f1ea))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.37.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Sep 8, 2021
# [1.37.0](v1.36.0...v1.37.0) (2021-09-08)

### Bug Fixes

* currency symbol handling ([#850](#850)) ([9637d89](9637d89))
* only show category link anchor tags if the category has a link ([#863](#863)) ([549f03a](549f03a))
* show all saved post types in specific posts field ([#857](#857)) ([42c25a9](42c25a9))

### Features

* make Donate Block 'thank you' text editable ([#854](#854)) ([7e8f1ea](7e8f1ea))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.37.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants