Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct button stacking on sent newsletters #1695

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: correct button stacking on sent newsletters #1695

merged 1 commit into from
Nov 8, 2024

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR is a near-twin of #1681, and fixes the button stacking issue that also happens after the newsletter is sent in WP 6.7.

See 1208604228632024-as-1208716676665710

How to test the changes in this Pull Request:

  1. Start with a test site running the latest WordPress 6.7 RC.
  2. Send a newsletter, or open an already-send newsletter in the editor.
  3. Note the button appearance (you may need to shrink your browser window down to less than 1400px wide to recreate):

CleanShot 2024-11-07 at 17 46 20

  1. Apply this PR and run npm run build.
  2. Repeat steps 2-3 and confirm that the buttons look okay now:

CleanShot 2024-11-07 at 17 44 48

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford requested a review from a team as a code owner November 8, 2024 01:47
@github-actions github-actions bot added [Status] Approved Ready to merge and removed [Status] Needs Review labels Nov 8, 2024
@laurelfulford
Copy link
Contributor Author

Thanks @adekbadek! 🙌

@laurelfulford laurelfulford merged commit 4e2688e into trunk Nov 8, 2024
11 checks passed
matticbot pushed a commit that referenced this pull request Nov 8, 2024
@semantic-release-bot
chore(release): 3.4.0-alpha.3 [skip ci]
aebe12f 
# [3.4.0-alpha.3](v3.4.0-alpha.2...v3.4.0-alpha.3) (2024-11-08)

### Bug Fixes

* correct button stacking on sent newsletters ([#1695](#1695)) ([4e2688e](4e2688e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.4.0-alpha.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 11, 2024
@semantic-release-bot
chore(release): 3.4.0 [skip ci]
949e5e5 
# [3.4.0](v3.3.3...v3.4.0) (2024-11-11)

### Bug Fixes

* avoid double notice components ([#1703](#1703)) ([b8e9130](b8e9130))
* avoid race condition between post-save sync & test ([#1679](#1679)) ([7bde119](7bde119))
* avoid Redux usage and related errors in non-newsletter email editors ([#1688](#1688)) ([d3f1f37](d3f1f37))
* correct button stacking on sent newsletters ([#1695](#1695)) ([4e2688e](4e2688e))
* dont html encode ampersands in subject ([#1686](#1686)) ([f178b23](f178b23))
* **mailchimp:** avoid duplicate audiences in Mailchimp UIs ([#1685](#1685)) ([44c1b12](44c1b12))
* move Preview, Send buttons to match Publish button location ([#1689](#1689)) ([72897f2](72897f2))
* preview & send buttons on WP 6.7 ([49450d3](49450d3))
* remove behavior to hide post title in newsletter editor ([#1701](#1701)) ([8a15cf5](8a15cf5))

### Features

* display list remote name on settings page ([#1672](#1672)) ([562d396](562d396))
@miguelpeixe miguelpeixe deleted the fix/button-stacking-after-send branch November 13, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

Assignees
No one assigned
Labels
released on @alpha [Status] Approved Ready to merge wp 6.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurelfulford @matticbot @adekbadek