Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout Picker Issues In Safari #216

Closed
jeffersonrabb opened this issue Jun 4, 2020 · 1 comment · Fixed by #165
Closed

Layout Picker Issues In Safari #216

jeffersonrabb opened this issue Jun 4, 2020 · 1 comment · Fixed by #165
Labels
Browser: Safari bug Something isn't working released User Interface

Comments

@jeffersonrabb
Copy link
Contributor

This will only be relevant after #165 lands, but there are a two layout problems in Safari in the Layout Picker modal.

  1. Preview Pane doesn't fill full space when empty:

Screen Shot 2020-06-04 at 9 57 41 AM

  1. After making a selection the left column empties out. It actually appears that the height of the overall container becomes the full height of the layout, which effectively pushes the thumbnails way down:

Screen Shot 2020-06-04 at 9 59 40 AM
adekbadek added a commit that referenced this issue Jun 4, 2020
@adekbadek
fix: safari fixes
ce91f53 
Closes #216
@adekbadek adekbadek mentioned this issue Jun 4, 2020
Merged
6 tasks
adekbadek added a commit that referenced this issue Jun 5, 2020
@adekbadek
feat: add layouts management (#165)
446674f 
Closes #31
Closes #216
matticbot pushed a commit that referenced this issue Jun 9, 2020
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
d6bca87 
# [1.1.0](v1.0.1...v1.1.0) (2020-06-09)

### Bug Fixes

* prevent deduplication in layout picker preview ([4a5721e](4a5721e)), closes [#199](#199)
* **posts-inserter:** prevent empty featured image rendering ([56a97c4](56a97c4)), closes [#201](#201)
* resolve excerpt length issue ([d40f98a](d40f98a))
* situation that overwrote mc campaign id ([8ecf564](8ecf564))
* update editor block paddings ([#195](#195)) ([eb100b8](eb100b8))
* when trashing post allow mailchimp api call to fail silently ([7e2d9c4](7e2d9c4))
* when trashing post allow mailchimp api call to fail silently ([8257451](8257451))

### Features

* add layouts management ([#165](#165)) ([446674f](446674f)), closes [#31](#31) [#216](#216)
* font picker ([#210](#210)) ([0234bf9](0234bf9))
@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Browser: Safari bug Something isn't working released User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add layouts management Automattic/newspack-newsletters
2 participants
@jeffersonrabb @matticbot