Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update editor block paddings #195

Merged
merged 10 commits into from
May 7, 2020
Merged

Update editor block paddings #195

merged 10 commits into from
May 7, 2020

Conversation

thomasguillot
Copy link
Contributor

@thomasguillot thomasguillot commented May 6, 2020

All Submissions:

Changes proposed in this Pull Request:

Once again, this is another attempt at bringing the editor closer to the final result... the sent newsletter.

I completely removed the margins and instead I'm relying on paddings.

Let me know what you think and if it works for you!

Closes #190

How to test the changes in this Pull Request:

  1. Switch to this branch
  2. Test all the available blocks. Don't be shy!
  3. You can send yourself a test or check the preview via Mailchimp.com https://admin.mailchimp.com/campaigns/preview-content-html?id=ID_OF_YOUR_NEWSLETTER

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This really brings the editor view much closer to the rendered email.

I've noticed one issue with button's padding in the editor (both regular and outline):

image

Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turned out I was using an older version of Gutenberg, on the newest version it looks fine 👌

@thomasguillot thomasguillot merged commit eb100b8 into master May 7, 2020
@thomasguillot thomasguillot deleted the fix/editor-padding branch May 7, 2020 17:04
matticbot pushed a commit that referenced this pull request Jun 9, 2020
# [1.1.0](v1.0.1...v1.1.0) (2020-06-09)

### Bug Fixes

* prevent deduplication in layout picker preview ([4a5721e](4a5721e)), closes [#199](#199)
* **posts-inserter:** prevent empty featured image rendering ([56a97c4](56a97c4)), closes [#201](#201)
* resolve excerpt length issue ([d40f98a](d40f98a))
* situation that overwrote mc campaign id ([8ecf564](8ecf564))
* update editor block paddings ([#195](#195)) ([eb100b8](eb100b8))
* when trashing post allow mailchimp api call to fail silently ([7e2d9c4](7e2d9c4))
* when trashing post allow mailchimp api call to fail silently ([8257451](8257451))

### Features

* add layouts management ([#165](#165)) ([446674f](446674f)), closes [#31](#31) [#216](#216)
* font picker ([#210](#210)) ([0234bf9](0234bf9))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlaid blocks in the editor
3 participants