Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If expiry isn't chosen for ad, you can't then pick a date and proceed #251

Closed
iAmSteveBeatty opened this issue Jul 1, 2020 · 1 comment · Fixed by #252
Closed

If expiry isn't chosen for ad, you can't then pick a date and proceed #251

iAmSteveBeatty opened this issue Jul 1, 2020 · 1 comment · Fixed by #252
Assignees
@adekbadek
Labels
bug Something isn't working released

Comments

@iAmSteveBeatty
Copy link

To reproduce:

  • Start a Newsletter ad.
  • type a word or two
  • hit publish
  • you should get a warning that says you can't publish without an expiration date. All good and expected through here.
  • then there's no option to proceed. If I pick a date in the future, the "publish" button become "schedule," but it's still not a functional button. For lack of the better term, it remains grayed-out.
@claudiulodro claudiulodro added the bug Something isn't working label Jul 1, 2020
adekbadek added a commit that referenced this issue Jul 6, 2020
@adekbadek
feat(ads): allow no expiry date on ads
ca1453a 
Closes #251
@adekbadek adekbadek mentioned this issue Jul 6, 2020
Merged
6 tasks
@adekbadek adekbadek self-assigned this Jul 7, 2020
adekbadek added a commit that referenced this issue Jul 7, 2020
@adekbadek
feat(ads): allow no expiry date on ads (#252)
eacb5f7 
Closes #251
matticbot pushed a commit that referenced this issue Jul 7, 2020
@semantic-release-bot
chore(release): 1.4.0 [skip ci]
643f2ba 
# [1.4.0](v1.3.0...v1.4.0) (2020-07-07)

### Bug Fixes

* resolve php notices ([#256](#256)) ([e854521](e854521))

### Features

* **ads:** allow no expiry date on ads ([#252](#252)) ([eacb5f7](eacb5f7)), closes [#251](#251)
* **mailchimp:** handle segmentation via tags ([#241](#241)) ([99f2f1f](99f2f1f)), closes [#21](#21)
* **mjml:** handle social icons block aligment options ([#257](#257)) ([ce10875](ce10875))
* support linked images ([#255](#255)) ([7f7ce8e](7f7ce8e))
@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adekbadek adekbadek

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ads: allow no expiry date Automattic/newspack-newsletters
4 participants
@claudiulodro @adekbadek @matticbot @iAmSteveBeatty