Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support linked images #255

Merged
merged 1 commit into from
Jul 7, 2020
Merged

feat: support linked images #255

merged 1 commit into from
Jul 7, 2020

Conversation

jeffersonrabb
Copy link
Contributor

@jeffersonrabb jeffersonrabb commented Jul 7, 2020 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Links applied to Image blocks don't render in emails.

Closes #253

How to test the changes in this Pull Request:

  1. On master with latest Gutenberg plugin create a Newsletter, add an image, apply a link to it.
  2. Send a test email to yourself. Observe the image is not linked.
  3. Switch to this branch. Save and send another test. Observe the image is linked as expected.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@jeffersonrabb jeffersonrabb requested a review from adekbadek July 7, 2020 00:45
@jeffersonrabb jeffersonrabb self-assigned this Jul 7, 2020
@jeffersonrabb jeffersonrabb added bug Something isn't working regression labels Jul 7, 2020
adekbadek
adekbadek approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@github-actions github-actions bot added the [Status] Approved Ready to merge label Jul 7, 2020
@jeffersonrabb jeffersonrabb merged commit 7f7ce8e into master Jul 7, 2020
@jeffersonrabb jeffersonrabb deleted the fix/image-links branch July 7, 2020 11:43
matticbot pushed a commit that referenced this pull request Jul 7, 2020
@semantic-release-bot
chore(release): 1.4.0 [skip ci]
643f2ba 
# [1.4.0](v1.3.0...v1.4.0) (2020-07-07)

### Bug Fixes

* resolve php notices ([#256](#256)) ([e854521](e854521))

### Features

* **ads:** allow no expiry date on ads ([#252](#252)) ([eacb5f7](eacb5f7)), closes [#251](#251)
* **mailchimp:** handle segmentation via tags ([#241](#241)) ([99f2f1f](99f2f1f)), closes [#21](#21)
* **mjml:** handle social icons block aligment options ([#257](#257)) ([ce10875](ce10875))
* support linked images ([#255](#255)) ([7f7ce8e](7f7ce8e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

Assignees

@jeffersonrabb jeffersonrabb

Labels
bug Something isn't working regression released [Status] Approved Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Links on Images Don't Translate To Emails
3 participants
@jeffersonrabb @matticbot @adekbadek