Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ads: allow no expiry date #252

Merged
merged 4 commits into from
Jul 7, 2020
Merged

Ads: allow no expiry date #252

merged 4 commits into from
Jul 7, 2020

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Closes #251.

How to test the changes in this Pull Request:

  1. Create a newsletter ad, do not an expiry date, publish
  2. Observe that it's listed as active in the newsletter ads view, with a note about not expiration date set
  3. Publish a newsletter, observe the ad is appended to the bottom

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@jeffersonrabb jeffersonrabb self-requested a review July 7, 2020 14:12
jeffersonrabb
jeffersonrabb approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@jeffersonrabb jeffersonrabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing I noticed is there is no way to unset an expiry date once you've done it. I'm not sure if this is a needed feature so I'm approving.

@github-actions github-actions bot added [Status] Approved Ready to merge and removed [Status] Needs Review labels Jul 7, 2020
@adekbadek
Copy link
Member Author

@jeffersonrabb That might be handy, added in 46ee3e1

@adekbadek adekbadek requested a review from jeffersonrabb July 7, 2020 15:00
@github-actions github-actions bot added [Status] Approved Ready to merge and removed [Status] Needs Review labels Jul 7, 2020
@adekbadek adekbadek merged commit eacb5f7 into master Jul 7, 2020
@adekbadek adekbadek deleted the add/infinite-ads branch July 7, 2020 16:53
matticbot pushed a commit that referenced this pull request Jul 7, 2020
@semantic-release-bot
chore(release): 1.4.0 [skip ci]
643f2ba 
# [1.4.0](v1.3.0...v1.4.0) (2020-07-07)

### Bug Fixes

* resolve php notices ([#256](#256)) ([e854521](e854521))

### Features

* **ads:** allow no expiry date on ads ([#252](#252)) ([eacb5f7](eacb5f7)), closes [#251](#251)
* **mailchimp:** handle segmentation via tags ([#241](#241)) ([99f2f1f](99f2f1f)), closes [#21](#21)
* **mjml:** handle social icons block aligment options ([#257](#257)) ([ce10875](ce10875))
* support linked images ([#255](#255)) ([7f7ce8e](7f7ce8e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffersonrabb jeffersonrabb jeffersonrabb approved these changes

Assignees
No one assigned
Labels
released [Status] Approved Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If expiry isn't chosen for ad, you can't then pick a date and proceed
3 participants
@adekbadek @matticbot @jeffersonrabb