Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct position of comment icon indicating current author #824

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Correct position of comment icon indicating current author #824

merged 2 commits into from
Mar 18, 2020

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

The theme adds an icon to comments made by the current post author.

Right now, that icon is oddly placed and it's always using Newspack's default blue -- this PR updates the position, and changes it to use the custom primary colour. It also removes some duplicate code that doesn't seem to do anything (the duplicate icons would just be stacked on top of each other).

Closes #819

How to test the changes in this Pull Request:

  1. Add a comment to a post your current user authored, and view on front-end:

image

  1. Apply the PR and run npm run build
  2. Confirm that the icon placement is next to the author's name, and that it's using your current primary colour:

image

  1. Try changing your custom colour to a dark colour if it's lighter, or a light colour if it's darker, to make sure the contrast works as expected:

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Mar 9, 2020
claudiulodro
claudiulodro requested changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@claudiulodro claudiulodro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this looks good. I noticed an issue with dark primary colors in my testing. Can you please confirm/deny? :)

newspack-theme/inc/color-patterns.php Outdated Show resolved Hide resolved
@claudiulodro claudiulodro added [Status] Needs Changes or Feeback The issue or pull request needs action from the original creator and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 17, 2020
@laurelfulford laurelfulford added [Status] Needs Review The issue or pull request needs to be reviewed and removed [Status] Needs Changes or Feeback The issue or pull request needs action from the original creator labels Mar 18, 2020
@laurelfulford
Copy link
Contributor Author

Thanks @claudiulodro 🤦‍♀ That contrast issue should now be fixed!

claudiulodro
claudiulodro approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@claudiulodro claudiulodro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest version looks good. 👍

@claudiulodro claudiulodro added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 18, 2020
@laurelfulford
Copy link
Contributor Author

Thanks Claudiu!

@laurelfulford laurelfulford merged commit 6778719 into master Mar 18, 2020
@laurelfulford laurelfulford deleted the fixes/819-author-comment branch March 18, 2020 17:56
matticbot pushed a commit that referenced this pull request Mar 24, 2020
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
6ce93ce 
# [1.3.0](v1.2.0...v1.3.0) (2020-03-24)

### Bug Fixes

* change way featured images are added to fix missing titles ([#837](#837)) ([7fb8ff2](7fb8ff2))
* correct position of comment icon indicating current author ([#824](#824)) ([6778719](6778719))
* prevent id selector format error ([#833](#833)) ([2fdb043](2fdb043))
* remove style overrides from h2 in cover blocks ([#834](#834)) ([15eb042](15eb042))
* remove top margin on accent-header in column ([#829](#829)) ([f72a529](f72a529))
* set max width for nested full and wide blocks ([#827](#827)) ([22e2655](22e2655))
* set size for above copyright widget titles ([#828](#828)) ([aa4231f](aa4231f))

### Features

* filters for super cool ad inserter placements ([#839](#839)) ([e3ac56b](e3ac56b))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiulodro claudiulodro claudiulodro approved these changes

Assignees
No one assigned
Labels
released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comments: Fix Author icon
3 participants
@laurelfulford @matticbot @claudiulodro