Filters for Super Cool Ad Inserter Ads

[jeffersonrabb]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This branch is meant to be tested with Automattic/newspack-ads#31. Complete testing instructions can be found in Automattic/newspack-ads#31.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[thomasguillot]

This doesn't seem to work properly when the ads are inside a narrow content area (Default or One column). Wide content area (One column wide) seems to behave as expected.

As a temporary fix, I'd recommend that we remove the page template check and just use $breakpoint = ceil( $breakpoint / 0.9 );. So something like:

function newspack_theme_newspack_ads_breakpoint( $breakpoint, $placement, $context ) {
	// Apply Responsive placement to widgets using Super Cool Ad Inserter.
	$breakpoint = ceil( $breakpoint / 0.9 );

	return $breakpoint;
}
add_filter( 'newspack_ads_breakpoint', 'newspack_theme_newspack_ads_breakpoint', 10, 3 );

From here we can add some CSS to make sure that the ads are not overflowing.

E.g. in /sass/blocks/_blocks.scss

//! Super Cool Ad Inserter Plugin
.scaip {
	overflow: hidden;

	amp-ad {
		display: block;
	}
}

Then we will need to find a solution for the narrow content when viewport is >= 782px which means we should be using $breakpoint = ceil( $breakpoint / 0.585 );

[adekbadek]

LGTM

[matticbot]

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀