Remove style overrides from h2 in cover blocks #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurelfulford
added
[Status] Needs Review
jeffersonrabb
added
[Status] Approved
|
Thanks Jeff! |
matticbot
pushed a commit
that referenced
this pull request
Mar 24, 2020
# [1.3.0](v1.2.0...v1.3.0) (2020-03-24) ### Bug Fixes * change way featured images are added to fix missing titles ([#837](#837)) ([7fb8ff2](7fb8ff2)) * correct position of comment icon indicating current author ([#824](#824)) ([6778719](6778719)) * prevent id selector format error ([#833](#833)) ([2fdb043](2fdb043)) * remove style overrides from h2 in cover blocks ([#834](#834)) ([15eb042](15eb042)) * remove top margin on accent-header in column ([#829](#829)) ([f72a529](f72a529)) * set max width for nested full and wide blocks ([#827](#827)) ([22e2655](22e2655)) * set size for above copyright widget titles ([#828](#828)) ([aa4231f](aa4231f)) ### Features * filters for super cool ad inserter placements ([#839](#839)) ([e3ac56b](e3ac56b))
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Originally the Cover block only allowed specific blocks -- like the Header block -- and added styles for them (like centring them).
The theme originally included override styles for the h2 to align it left that are no longer needed. On top of that, they're also currently preventing you from being able to centre the h2. It's time to remove these.
How to test the changes in this Pull Request:
npm run build.h2(by clicking align center again). Confirm that it now aligns in the default way, to the left.Other information: