Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct dropdown colors for Newspack Sacha #1111

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Similar to #1110, this PR fixes some dropdown colour inconsistencies in Newspack Sacha.

How to test the changes in this Pull Request:

  1. Start with a test site with Nespack Sacha.
  2. Set up the site with a short header, with a solid background colour.
  3. View on the front-end and open a dropdown menu; note that the dropdown uses the primary colour on hover, instead of the correct darker grey:

image

  1. Apply the PR and run npm run build.
  2. Confirm that the menu dropdown is now dark grey:

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Oct 14, 2020
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖖

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Oct 20, 2020
@laurelfulford
Copy link
Contributor Author

🥳

@laurelfulford laurelfulford merged commit 3748d6f into master Oct 20, 2020
@laurelfulford laurelfulford deleted the fixes/sacha-menu-hover branch October 20, 2020 15:07
matticbot pushed a commit that referenced this pull request Oct 20, 2020
# [1.21.0-alpha.1](v1.20.2...v1.21.0-alpha.1) (2020-10-20)

### Bug Fixes

* correct dropdown colors for Newspack Katharine ([#1110](#1110)) ([01ee559](01ee559))
* correct dropdown colors for Newspack Sacha ([#1111](#1111)) ([3748d6f](3748d6f))
* make pullquote citations inherit correct color ([#1116](#1116)) ([f537fd6](f537fd6))
* make sure accent header in the editor matches the front end ([#1112](#1112)) ([11e4970](11e4970))
* prevent captions from getting cut off with image-beside setting ([#1113](#1113)) ([2d779a8](2d779a8))
* target only smaller screen sizes for image block caption fix ([#1109](#1109)) ([0f8a7bc](0f8a7bc))

### Features

* add option to turn off Yoast's primary category functionality ([#1104](#1104)) ([95083c7](95083c7))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.21.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Oct 20, 2020
# [1.21.0](v1.20.2...v1.21.0) (2020-10-20)

### Bug Fixes

* correct dropdown colors for Newspack Katharine ([#1110](#1110)) ([01ee559](01ee559))
* correct dropdown colors for Newspack Sacha ([#1111](#1111)) ([3748d6f](3748d6f))
* make pullquote citations inherit correct color ([#1116](#1116)) ([f537fd6](f537fd6))
* make sure accent header in the editor matches the front end ([#1112](#1112)) ([11e4970](11e4970))
* prevent captions from getting cut off with image-beside setting ([#1113](#1113)) ([2d779a8](2d779a8))
* target only smaller screen sizes for image block caption fix ([#1109](#1109)) ([0f8a7bc](0f8a7bc))

### Features

* add option to turn off Yoast's primary category functionality ([#1104](#1104)) ([95083c7](95083c7))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants