Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add padding to the file block when it has a background #2168

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix: add padding to the file block when it has a background #2168

merged 1 commit into from
Jul 28, 2023

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

The File block will have an option to add a background colour in WordPress 6.3; right now, the theme doesn't add a padding to go with the background option, which makes things look a little weird. This PR adds a bit of padding to the File block when it has a background colour.

See 1204989005688794-as-1205128703011536

How to test the changes in this Pull Request:

  1. Start on a test site running the latest WordPress 6.3 RC.
  2. Create a page and add a File block, and assign it a file. In the right sidebar, give the block a background colour.
  3. Note that the block has no padding on the front-end or in the editor, which makes the background look a little strange:

image

  1. Apply the PR and run npm run build.
  2. Check the page again on the front-end and in the editor, and confirm that the block now has padding when it has a background:

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added [Status] Needs Review The issue or pull request needs to be reviewed wp 6.3 labels Jul 24, 2023
@laurelfulford laurelfulford requested a review from a team as a code owner July 24, 2023 22:37
@leogermani leogermani self-requested a review July 28, 2023 17:16
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jul 28, 2023
@laurelfulford
Copy link
Contributor Author

Thanks @leogermani!

@laurelfulford laurelfulford merged commit 5a29efa into master Jul 28, 2023
@laurelfulford laurelfulford deleted the fix/file-block-background-padding branch July 28, 2023 17:39
matticbot pushed a commit that referenced this pull request Aug 8, 2023
@semantic-release-bot
chore(release): 1.77.0-alpha.1 [skip ci]
af0f531 
# [1.77.0-alpha.1](v1.76.0...v1.77.0-alpha.1) (2023-08-08)

### Bug Fixes

* add padding to the file block when it has a background ([#2168](#2168)) ([5a29efa](5a29efa))
* improve new search setting appearance for WP 6.3 ([#2167](#2167)) ([a87f7e5](a87f7e5))

### Features

* add downloads details to checkout ([#2162](#2162)) ([81c52f5](81c52f5))
* add styles for the details block ([#2165](#2165)) ([25832c3](25832c3))
* add styles for the footnote block ([#2166](#2166)) ([22732f5](22732f5))
* add Threads logo to the social links menu ([#2158](#2158)) ([64bf6c1](64bf6c1))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.77.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Aug 8, 2023
@semantic-release-bot
chore(release): 1.77.0 [skip ci]
3cf093d 
# [1.77.0](v1.76.0...v1.77.0) (2023-08-08)

### Bug Fixes

* add padding to the file block when it has a background ([#2168](#2168)) ([5a29efa](5a29efa))
* improve new search setting appearance for WP 6.3 ([#2167](#2167)) ([a87f7e5](a87f7e5))

### Features

* add downloads details to checkout ([#2162](#2162)) ([81c52f5](81c52f5))
* add styles for the details block ([#2165](#2165)) ([25832c3](25832c3))
* add styles for the footnote block ([#2166](#2166)) ([22732f5](22732f5))
* add Threads logo to the social links menu ([#2158](#2158)) ([64bf6c1](64bf6c1))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.77.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogermani leogermani leogermani approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge wp 6.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurelfulford @matticbot @leogermani