Add Tracks Analytics on frontend #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Chris Zarate <chris.zarate@automattic.com>
chriszarate
reviewed
Nov 5, 2024
src/blocks/remote-data-container/components/field-shortcode/FieldShortcodeButton.tsx
Outdated
Show resolved
Hide resolved
chriszarate
reviewed
Nov 5, 2024
src/blocks/remote-data-container/components/modals/InputModal.tsx
Outdated
Show resolved
Hide resolved
chriszarate
reviewed
Nov 5, 2024
| @@ -66,6 +66,7 @@ function BoundBlockEdit( props: BoundBlockEditProps ) { | |||
| attributes={ attributes } | |||
| availableBindings={ availableBindings } | |||
| blockName={ blockName } | |||
| remoteDataName={ remoteDataName } | |||
There was a problem hiding this comment.
Instead of prop drilling the container block name, I think we should just prop drill the sendTracksEvent function with the data_source_type baked in
There was a problem hiding this comment.
We'll need prop drilling in either case, to me passing blockName seems simpler than passing the function.
These changes improve the overall structure and maintainability of the codebase.
… REMOTE_DATA_BLOCKS const
maxschmeling
approved these changes
Nov 14, 2024
| @@ -51,11 +55,23 @@ export function BlockBindingControls( props: BlockBindingControlsProps ) { | |||
| function updateFieldBinding( target: string, field: string ): void { | |||
| if ( ! field ) { | |||
| removeBinding( target ); | |||
| sendTracksEvent( 'remotedatablocks_remote_data_container_actions', { | |||
| action: 'remove_binding', | |||
| data_source_type: getBlockDataSourceType( remoteDataName ), | |||
There was a problem hiding this comment.
Should this also have a remote_data_field property?
There was a problem hiding this comment.
For remove_binding action we don't get field value and that's why I haven't included remote_data_field in track props. Let me know if you think we should include it, I will find an alternative.
mehmoodak
added a commit
that referenced
this pull request
Nov 21, 2024
Pull request #185 has caused an issue with the withBlockBinding tests, which attempt to use the Tracks API. To resolve this, the Tracks function was mocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Tracks Analytics by using the
@automattic/calypso-analyticspackage. With each track event, the following properties will be tracked:Note: This tracking will only work if site is hosted on VIP Platform or if the analytics is enabled via filter.
How to test?
Create a site using
vip dev-envwhich will have the MU Plugins.Move
remote-data-blocksplugin to thepluginsfolder.Add filter in
plugin-loader.phpto enable tracking.Checkout this wp-calypso PR,
buildandlinkthe@automattic/calypso-analyticspackage.To allow tracking on local env comment check on PHP and JS side.
Trigger track events, use "Live View" to verify that the events are getting logged.