Tracks: Add Remote Data Blocks in the list of allowed sources #96007
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
matticbot
added
[Status] Needs Review
There was a problem hiding this comment.
LGTM 👍
Make sure to publish the new version:
https://github.com/Automattic/wp-calypso/blob/trunk/docs/monorepo.md#publishing
| ! /^calypso(?:_[a-z0-9]+){2,}$/.test( eventName ) && | ||
| ! /^jetpack(?:_[a-z0-9]+){2,}$/.test( eventName ) && | ||
| ! /^remotedatablocks(?:_[a-z0-9]+){2,}$/.test( eventName ) && | ||
| ! /^wpcom_dsp_widget(?:_[a-z0-9]+){2,}$/.test( eventName ) && |
There was a problem hiding this comment.
Not a blocker for this PR, but a nice potential follow-up: would be nice if we avoid this regex repetition here by having an array of allowed source prefixes declared and checking against that.
There was a problem hiding this comment.
Fixed in 786e273. Please have a look.
github-actions
bot
removed
the
[Status] Needs Review
Deployed 🚢 |
Updating `calypso-analytics` package to version `1.1.3` which contains whitelisting logic (Automattic/wp-calypso#96007) for `remotedatablocks` source.
Proposed Changes
Update
@automattic/calypso-analyticspackage to add "Remote Data Blocks" in the list of allowed sources.Why are these changes being made?
@automattic/calypso-analyticsin the "Remote Data Blocks" plugin and, as a result, need to allow it.Testing Instructions
@automattic/calypso-analyticspackage.Pre-merge Checklist