Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog category names #7143

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Fix changelog category names #7143

merged 1 commit into from
Sep 1, 2023

Conversation

m1r0
Copy link
Member

@m1r0 m1r0 commented Aug 31, 2023

Resolves #7113

This PR reverts the changelog category names changed in #6804.

I wasn't able to find a way to add a category description, so a future P2 post will explain how to use them.

Proposed Changes

  • Revert to the old changelog category names.

Testing Instructions

  1. Run npm run changelog.
  2. Make sure the category names are correct.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@m1r0 m1r0 added this to the 4.16.2 milestone Aug 31, 2023
@m1r0 m1r0 self-assigned this Aug 31, 2023
@m1r0 m1r0 requested a review from a team August 31, 2023 19:23
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #7143 (d906e71) into trunk (05932d8) will increase coverage by 0.11%.
Report is 18 commits behind head on trunk.
The diff coverage is 91.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk    #7143      +/-   ##
============================================
+ Coverage     49.36%   49.47%   +0.11%     
- Complexity    10546    10569      +23     
============================================
  Files           575      578       +3     
  Lines         44537    44602      +65     
  Branches        402      402              
============================================
+ Hits          21987    22069      +82     
+ Misses        22223    22206      -17     
  Partials        327      327              
Files Changed Coverage Δ
...d-jobs/class-sensei-scheduler-action-scheduler.php 83.33% <0.00%> (ø)
includes/class-sensei.php 23.14% <0.00%> (-0.28%) ⬇️
...ternal/action-scheduler/class-action-scheduler.php 100.00% <100.00%> (ø)
...er/migrations/class-student-progress-migration.php 81.63% <100.00%> (+0.73%) ⬆️
...nt-progress/jobs/class-migration-job-scheduler.php 100.00% <100.00%> (ø)
...rnal/student-progress/jobs/class-migration-job.php 100.00% <100.00%> (ø)
...al/student-progress/tools/class-migration-tool.php 100.00% <100.00%> (+68.96%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc6e89...d906e71. Read the comment docs.

Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as before 👍

@m1r0 m1r0 merged commit 0013028 into trunk Sep 1, 2023
25 checks passed
@m1r0 m1r0 deleted the update/changelog-sections branch September 1, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix changelog categories having example descriptions
2 participants