Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Github-flavoured Markdown #309

Closed
eblade opened this issue May 3, 2016 · 8 comments
Closed

Enable Github-flavoured Markdown #309

eblade opened this issue May 3, 2016 · 8 comments
Labels
enhancement Improve existing functionality [priority] low Address this when there is time
Milestone

Comments

@eblade
Copy link

eblade commented May 3, 2016

Given how I assume this app is built (not too familiar with Electron, but it looks web-ish to me), would it be possible to use for instance this renderer marked to enable Github-flavoured Markdown (GFM). The main feature for me would be syntax highlighting for a number of languages.

@davewhitley davewhitley added the enhancement Improve existing functionality label May 3, 2016
@davewhitley davewhitley added this to the v1.1 milestone May 31, 2016
@roundhill
Copy link
Contributor

We're already using marked, so I think we just need to enable the gfm option 👍

@davewhitley davewhitley added the [priority] low Address this when there is time label Jun 10, 2016
@mjio
Copy link

mjio commented Jul 18, 2016

+1 on syntax highlighting support.

Are there plans to also enable Markdown for the OSX application?

@rnewton
Copy link
Contributor

rnewton commented Oct 19, 2016

According to the readme and the code, marked has gfm enabled by default. https://github.com/chjj/marked/blob/master/lib/marked.js#L1242

To get syntax highlighting, you need to add another library like https://github.com/isagalaev/highlight.js

@dmsnell
Copy link
Member

dmsnell commented Nov 5, 2016

Will be resolved when #309 merges.

@eblade
Copy link
Author

eblade commented Nov 9, 2016

Looking forward to it!

dmsnell pushed a commit that referenced this issue Nov 12, 2016
* Enable syntax highlighting (#309)
@geekpete
Copy link

geekpete commented Feb 24, 2017

GFM seems to work for me by wrapping code in ``` backticks.

This displays fine in the electron based client preview but breaks in the web version preview.

Can we get the web version to have parity with this feature?

I've previously been wrapping code in <pre> </pre>

@rachelsquirrel
Copy link

A request in #3241877-t for Fountain script (https://fountain.io/), which is a markup language for writers.

@dmsnell
Copy link
Member

dmsnell commented Aug 23, 2017

This should have been fixed in the rollout of the showdown renderer in #577.

@dmsnell dmsnell closed this as completed Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality [priority] low Address this when there is time
Projects
None yet
Development

No branches or pull requests

8 participants