Markdown: Replace marked with showdown parser/printer
#577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`marked` doesn't appear to have been maintained for a while while `showdown` has more recent contributions. Further, `marked` was missing some functionality that we wanted. Namely, we wanted an equivalence with Github-flavored Markdown (gfm) and `showdown` does it better. In this patch we've changed the way we are inserting the content. Instead of using `dangerouslySetInnerHTML` we're statefully rendering the content into the DOM and then manipulating it. This change provides an easier way to interact with the rendered content because we can operate at the DOM level instead of at the string level. For example, this is how highlighting now gets inserted. **Notable changes** - Todo items render (though they can only be changed in the plaintext view) - Tables render - Code blocks highlight based on their language - Certain dirty/malicious content gets sanitized before display **Questions** - Since the todo items render but aren't editable it could be confusing for someone to use, misleading them into thinking it's supposed to work
|
Obviated by the merge of #579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
markeddoesn't appear to have been maintained for a while whileshowdownhas more recent contributions. Further,markedwas missingsome functionality that we wanted. Namely, we wanted an equivalence with
Github-flavored Markdown (gfm) and
showdowndoes it better.In this patch we've changed the way we are inserting the content.
Instead of using
dangerouslySetInnerHTMLwe're statefully renderingthe content into the DOM and then manipulating it. This change provides
an easier way to interact with the rendered content because we can
operate at the DOM level instead of at the string level. For example,
this is how highlighting now gets inserted.
Notable changes
view)
Questions
for someone to use, misleading them into thinking it's supposed to
work