Fix crash when receiving remote change in unfocused editor #1195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an uncaught bug in #1193, where we get a WSOD when the selected note receives a remote change while the editor is unfocused.
This was caused by the same strange behavior we worked around in
getCurrentBlock()
, where the selectionState methodsgetAnchorKey()
andgetFocusKey()
could sometimes return aContentBlock
instead of the key string.To test
→ Should not result in a WSOD