Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hacky focus manipulation in DraftJS #1219

Merged
merged 3 commits into from
Feb 28, 2019
Merged

Conversation

mirka
Copy link
Member

@mirka mirka commented Feb 22, 2019

I finally figured out what was causing the strange glitches that made me write some really hacky workarounds in #1193 and #1195. It was caused by focus events originating from NoteDetail, not NoteContentEditor! 💥

Testing

These things should work as expected:

  • Checkboxes
  • In the Note List, switching from a written note to an empty note (and vice versa)
  • Place the cursor somewhere in the note text, and then create a new note
  • Create a new note while the editor is not focused
  • Remote changes coming in to the currently selected note

Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So awesome! Nice job, it tested really well. Bye hacks 💥

@mirka mirka merged commit 891b3c5 into master Feb 28, 2019
@mirka mirka deleted the chore/remove-focus-hacks branch February 28, 2019 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants