Stories library part 9.1 - added errorNotification Delete pendingIntent loader and base error notification ID setter #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test the changes on this Pull Request by downloading the APK here. |
…e, so the baseErrorNotificationID is set first of all
mzorz
changed the title
mzorz
changed the title
mzorz
changed the title
mzorz
changed the base branch from
feature/wp-stories-part91-base-notif-id
to
feature/wp-stories-part9-clean-todo-toast
This was referenced May 30, 2020
| @@ -199,7 +203,23 @@ abstract class ComposeLoopFrameActivity : AppCompatActivity(), OnStoryFrameSelec | |||
| } | |||
| // Setup notification intent for notifications triggered from the FrameSaveService.FrameSaveNotifier class | |||
| notificationIntentLoader?.let { | |||
| // set the base notification Error Id. This is given on purpose so the host app can give a unique | |||
| // set of notific ations ID to base our error notifications from, and avoid collision with other | |||
There was a problem hiding this comment.
Suggested change
| // set of notific ations ID to base our error notifications from, and avoid collision with other | |
| // set of notifications ID to base our error notifications from, and avoid collision with other |
😅
| // set the base notification Error Id. This is given on purpose so the host app can give a unique | ||
| // set of notific ations ID to base our error notifications from, and avoid collision with other | ||
| // notifications the host app may have | ||
| // IMPORTANT: this needs to be the first call in the methods linedup for NotificationIntentLoader |
There was a problem hiding this comment.
Suggested change
| // IMPORTANT: this needs to be the first call in the methods linedup for NotificationIntentLoader | |
| // IMPORTANT: this needs to be the first call in the methods lined up for NotificationIntentLoader |
jd-alexander
approved these changes
Jun 20, 2020
There was a problem hiding this comment.
Thanks for these changes @mzorz This looks good! LGTM 🚢 I left some minor typo comments but just wanted to merge this to get things moving 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #359
Related WPAndroid PR: wordpress-mobile/WordPress-Android#12059
This PR adds an interface so to be able to set the error notification base ID from the host app. This is useful to avoid potential reuse of the same notification ID by some other notification in the host app.
Also, augmented the
NotificationIntentLoaderinterface with methodloadPendingIntentForErrorNotificationDeletionso pending intent for notificatiton Dismiss can also be loaded / set from the host app, enabling tracking and customizable actions when an error notification is dismissed.