-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WP Stories integration - setting the base error notification ID and setDelete PendingIntent for error notification #12059
Conversation
… with PostUploadNotifier
…nted loader interface for loading notification dismiss PendingIntent
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APK here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes @mzorz I tested and I was able to reproduce the notification error. I added an Exception
to the FrameSaveManager
to simulate an error before an image frame was saved. LGTM 🚢
Builds on top of #12045
This PR sets the base error notification ID from the WPAndroid app to avoid collision with
PostUploadNotifier
.Also, implements the PendingIntent loader for when an error notification is dismissed, and keeps tracks
Finally, we added the following notification types:
of which currently only
STORY_SAVE_ERROR
is used / needed at this point.To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.