-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WP Stories integration - implement StoryNotificationTrackerProvider interface #12068
WP Stories integration - implement StoryNotificationTrackerProvider interface #12068
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APK here. |
…ture/wp-stories-part10-tracks-notifications
@@ -995,4 +1005,32 @@ public void onTrimMemory(final int level) { | |||
} | |||
} | |||
} | |||
|
|||
private class StoryNotificationTrackerProvider implements NotificationTrackerProvider { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mzorz what do you think about putting this class into another file? Just checking because this class is getting a bit big. Let me know though because it's also a really small class 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes @mzorz I followed the testing instructions and I achieved the expected outcome. I really like this implementation 😉 LGTM 🚢
This PR builds on top of #12059
This PR implements the new
StoryNotificationTrackerProvider
interface, which allows the host app to be signaled of when a Notification is being produced by the StorySaveService in the Stories library. Then, it can properly channel the event through to its ownSystemNotificationsTracker
.Also in this PR we're checking
ARG_NOTIFICATION_TYPE
for when an error notification is tapped and properly tracking it down in StoryComposerActivity (see onCreate() in that class).To test:
saveImageFromPhotoEditorViewAsLoopFrameFile().
trackShownNotification
method implemented in the WordPress class is executed. (placing a breakpoint there should be enough).trackTappedNotification
method is executed as well.PR submission checklist:
RELEASE-NOTES.txt
if necessary.