Merge pull request #118 from Automattic/fix/update-dependencies #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gikaragia
requested review from
jom,
alexsanford,
renatho,
donnapep and
donnchawp
renatho
approved these changes
Jan 15, 2020
gikaragia
changed the title
|
Hey @donnchawp do we need this one released? Is this something that you will look into? I have no problem doing it although I'm guessing that I will probably need to be the owner of the plugin to do it, correct? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the dependencies to the latest version and removes a call of a deprecated function.
Testing
With the updated dependencies, there are a few changes in the minified JS file. To test them, I have followed these steps:
npm run build(there is an error in the process with no impact which is caused by this issue)