Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vulnerabilities #132

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Fix vulnerabilities #132

merged 2 commits into from
Apr 6, 2020

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Apr 1, 2020

Overview

Fix the vulnerabilities and update the cgb-scripts package to the last version.

Testing

  1. Run the build with the current version and save the file content for comparison.
  2. Run the build in this branch.
  3. Compare both. It should be the same.

Also, to confirm if everything continues working properly (copied from #118):

  1. I installed the plugin in a local test site.
  2. I created a post with a Syntax Highlighter block and tested it in the frontend.
  3. I navigated to the admin settings page to ensure that there are no errors.

@renatho renatho added the dependencies Pull requests that update a dependency file label Apr 1, 2020
@renatho renatho requested review from alexsanford and gikaragia April 1, 2020 16:21
@renatho renatho self-assigned this Apr 1, 2020
@renatho renatho changed the title Fix/vulnerabilities Fix vulnerabilities Apr 1, 2020
@alexsanford alexsanford added this to the 3.5.3 milestone Apr 3, 2020
@renatho renatho requested review from yscik, donnapep and jom April 3, 2020 19:18
gikaragia
gikaragia approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@gikaragia gikaragia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well!

@renatho renatho merged commit 2a684b0 into master Apr 6, 2020
@renatho renatho deleted the fix/vulnerabilities branch April 6, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gikaragia gikaragia gikaragia approved these changes

@alexsanford alexsanford Awaiting requested review from alexsanford

@yscik yscik Awaiting requested review from yscik

@donnapep donnapep Awaiting requested review from donnapep

@jom jom Awaiting requested review from jom

Assignees

@renatho renatho

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v3.5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@renatho @gikaragia @alexsanford