Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skatepark: Final issues #5471

Closed
MaggieCabrera opened this issue Feb 7, 2022 · 0 comments · Fixed by #5523
Closed

Skatepark: Final issues #5471

MaggieCabrera opened this issue Feb 7, 2022 · 0 comments · Fixed by #5523
Assignees
Labels
[Theme] Skatepark Automatically generated label for Skatepark.

Comments

@MaggieCabrera
Copy link
Contributor

MaggieCabrera commented Feb 7, 2022

After a call with @kjellr this is the list of what Skatepark needs to be ready to launch:

  • Changing colors in the customizer on dotcom is not applying to duotone in the frontend. If we can't solve this easily, the consensus is that we just remove the customizer stuff from the theme altogether.
  • Kjell is going to work on the home template and we'll include that to the theme instead of having a static page like the demo had until now. (Home: CA8Gb16mt9yYNWOiVLAWak-fi-2981%3A2284) Skatepark: new Home template #5491
  • The spacing between menu items is very short, this might be caused by CSS Blockbase: fixed spacing for header wide #5472
  • There is a block pattern for post navigation that shows errors on the editor and the pattern inserter. (I can't reproduce this anymore!)
  • Remove as much CSS as possible from the theme and refactor what we possibly can such as:

After removing the excess CSS we'd need another review from design to make sure all is acceptable for launch. The idea behind this is that all this extra CSS makes it harder on us when things change and users already have content in their pages. We can't go back and remove the CSS that will break that content. Instead, if everything is handled by the blocks, we can alter the block patterns and the change will only affect patterns that have not yet been placed on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Skatepark Automatically generated label for Skatepark.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant