-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try making skatepark standalone block theme #5523
Conversation
I think this is all fine, its the same approach we use for other block themes. . We will probably want to remove this extra CSS when that stuff is in Gutenberg, but we're not adding additional complexity. For the patterns I think we'll want to use the patterns from the directory instead when we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I tried that but I don't think it's possible unless the social links are decoupled from the navigation block. Either everything is in the same line or everything is vertical, I didn't find a way to make the line break between the links and the social links without adding CSS. |
@kjellr if you give a 👍 we can merge and deploy to .org |
Thanks @MaggieCabrera! Just a handful of notes on my end: I'm seeing a lack of left/right padding on small screens: Also, it seems weird that "Next Post" shows up here, even when there's no next post: I think the best solution is just to hide those Previous/Next Post titles completely for now. We can probably also remove the block pattern for this as well. On the homepage, the previous & next buttons appear too close to the posts themselves, so they're easy to miss. Let's add some margin/padding/separator or something to space them out. The extra space should match the space between the "Latest Posts" header and the post below it.
For some reason, separators in the editor appear less opaque than they do on the front end. Additionally, if you apply a custom color, they lose the custom width we define: I think we should remove the "Two Columns of Text" pattern. I'm not a fan of the text hierarchy, and it also doesn't scale well. |
8af1109
to
34573d8
Compare
2c7d80e
to
c85ac7f
Compare
Thanks for the review @kjellr!
Yeah, we were missing the correct custom variables for that, it should work fine now I fixed all the other issues as well, so this should be ready for another review |
Thanks, @MaggieCabrera! I pushed a couple quick updates:
This should be ready to go! |
Changes proposed in this Pull Request:
This PR converts Skatepark from a Blockbase child to a standalone block theme.
Related issue(s):
Closes #5471