Skatepark: new Home template #5491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
added
the
[Theme] Skatepark
kjellr
reviewed
Feb 10, 2022
| return array( | ||
| 'title' => __( 'Block patterns for home page', 'skatepark' ), | ||
| 'categories' => array( 'skatepark' ), | ||
| 'inserter' => false, |
There was a problem hiding this comment.
It might make sense to prefix this filename with hidden like we did in Twenty Twenty-Two. That way it's super-clear that this one won't be shown in the inserter.
kjellr
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
This looks great! I pushed one minor change, decreasing the wide width value by ~30px to push "through" onto the second line. May be a slight over-reaction, but it eliminates the "skateboarding" widow, it's simple, and it doesn't negatively effect anything else. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR includes the new homepage following this design CA8Gb16mt9yYNWOiVLAWak-fi-2981%3A2284
Related issue(s):
#5471