Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Feature Hints #1333

Closed
dartiss opened this issue Oct 22, 2019 · 3 comments
Closed

Disable Feature Hints #1333

dartiss opened this issue Oct 22, 2019 · 3 comments
Labels
[Type] Enhancement

Comments

@dartiss
Copy link

dartiss commented Oct 22, 2019 •
edited
Loading

As per a discussion with @jeherve at https://a8c.slack.com/archives/CBG1CP4EN/p1571740982220600, it would make sense to disable Feature Hints for all VIP Go clients.

This would require the code here to be added to vip-jetpack.php.

Why? Because although we disable the use of plugin search, the featured hints part of this is still active and can fail, cause errors, etc. It just makes sense to therefore switch this off as well.
@dartiss dartiss assigned dartiss and unassigned dartiss Oct 22, 2019
GaryJones added a commit that referenced this issue Nov 22, 2019
@GaryJones
Jetpack: Disable Jetpack feature hints
cb11606 
Fixes #1333.
@GaryJones GaryJones mentioned this issue Nov 22, 2019
Closed
4 tasks
@mjangda
Copy link
Member

mjangda commented Nov 22, 2019

That sounds like something that should be fixed upstream in Jetpack? (If things are actively breaking, then we should definitely deploy Gary's fix.)

@jeherve
Copy link
Member

jeherve commented Nov 22, 2019

Related: Automattic/jetpack#14108

@GaryJones
Copy link
Contributor

Closing to defer to upstream fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jetpack: Disable Jetpack feature hints Automattic/vip-go-mu-plugins
4 participants
@mjangda @GaryJones @jeherve @dartiss