Clean Up Codebase and Remove Obsolete "wallets" Feature Flags and Implementations #10058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpressutto5
changed the title
gpressutto5
force-pushed
the
remove-tokenized-cart-ece-flags
branch
from
2940585 to
91a482a
Compare
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
gpressutto5
requested review from
a team and
danielmx-dev
and removed request for
a team
|
Size Change: -18.5 kB (-1%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
danielmx-dev
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
The changes look fine and I was able to test Google Pay successfully in several flows (Product Details, Shortcode/Blocks Checkout, Shortcode/Blocks Cart). I think there shouldn't be any issues with Apple Pay as well, but if we can find someone with their environment already set up to do some quick testing that would be great.
This was referenced Jan 7, 2025
Open
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9725
Changes proposed in this Pull Request
This PR removes the old implementation of the ECE and removes the feature flag now that the Tokenized Cart ECE is the default.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge