Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial payment form styling #152

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Initial payment form styling #152

merged 1 commit into from
Jul 26, 2019

Conversation

dechov
Copy link
Contributor

@dechov dechov commented Jul 25, 2019

Addresses #57 (but will leave open for design review)

Changes proposed in this Pull Request

  • Adds WC core form and error structure for default styling, and some light styling on the field.
  master this branch
default
error

Testing instructions

  • Select the payment method in checkout and verify improved spacing
  • Enter invalid input and verify proper error styling
  • Tested on mobile (or does not apply)

@dechov
Initial payment form styling
4ccdc82 
WC core form and error structure, and light styling.
@dechov dechov requested a review from a team July 25, 2019 22:53
@RadoslavGeorgiev RadoslavGeorgiev self-requested a review July 26, 2019 12:20
RadoslavGeorgiev
RadoslavGeorgiev approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@RadoslavGeorgiev RadoslavGeorgiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one small comment for a potential change, but everything looks good. :shipit:

includes/class-wc-payment-gateway-wcpay.php Show resolved Hide resolved
@RadoslavGeorgiev RadoslavGeorgiev mentioned this pull request Jul 26, 2019
Closed
@dechov dechov merged commit 71f177f into master Jul 26, 2019
@dechov dechov deleted the fix/57-payment-form-initial-styling branch July 26, 2019 17:27
@dechov dechov mentioned this pull request Jul 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RadoslavGeorgiev RadoslavGeorgiev RadoslavGeorgiev approved these changes

@allendav allendav allendav left review comments

Assignees
No one assigned
Labels
pr: ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dechov @allendav @RadoslavGeorgiev