Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove brand identification in checkout and tweak styles #154

Merged
merged 3 commits into from
Jul 30, 2019

Conversation

dechov
Copy link
Contributor

@dechov dechov commented Jul 30, 2019

Fixes #22

Changes proposed in this Pull Request

  • Since WooCommerce (Payments) is not a customer-facing brand, this change removes mention from the default gateway title and description.
  • Also, the default description is now empty, as there is currently nothing that is in need of verbal instruction [#].
  • Finally, the styles are touched up a bit, primarily to avoid wasting space.

Default:

Error state:

With description added:

(This uses a <legend> element within the <fieldset>, but can revert to <p> if that's best, in which case we should just wrap the description in wpautop.)

Testing instructions

  • Go to Checkout screen with WooCommerce Payments enabled
  • Verify brand, copy, and appearance changes

  • Tested on mobile (or does not apply)

@dechov dechov requested a review from a team July 30, 2019 19:07
@dechov dechov merged commit 0e65042 into master Jul 30, 2019
@dechov dechov deleted the update/22-remove-customer-facing-brand-identification branch July 30, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Determine (or remove) customer-facing brand identification
2 participants