Assign callbacks to gateway-specific actions in the abstract checkout class to avoid unnecessary duplication #5246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.09 MB ℹ️ View Unchanged
|
timur27
requested review from
a team and
mdmoore
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5117
Changes proposed in this Pull Request
This PR:
Testing instructions 🔴 🟢
1️⃣ Test hook invocation, responsible for removing setup intent from the session.
You cannot update this SetupIntent because it has already succeeded.usually appear. In this step, we'd like to confirm that we don't see such errors.2️⃣ Test payment intent removal callback invocation
Confirm there are no errors in the two following use cases (does not matter if you save the payment method or not):
3️⃣ Test fixed duplicated notices when saving SEPA
Payment method successfully added.notice after being redirected to the payment method list.4️⃣ Test if appearance callbacks are invoked
To check if
save_upe_appearance_ajaxandclear_upe_appearance_transientcallbacks are invoked:clear_upe_appearance_transientmethod is invoked and the debugger stops at the breakpoint. In my case, I switched from Storefront to Twenty Twenty-Two.save_upe_appearance_ajax()method is invoked and debugger stops at the breakpoint.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge