Remove 'View dispute' link in Transaction Timeline #7088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -37 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
… details page is enabled, remove View dispute link on transaction details page.
…of github.com:Automattic/woocommerce-payments into fix/6928-remove-transaction-details-view-dispute-link
… on transaction details page is enabled.
…nsaction details page.
Jinksi
commented
Oct 5, 2023
There was a problem hiding this comment.
@shendy-a8c I can't approve this as original PR author, but I have tested this and have confirmed that the View Dispute link is no longer rendered on the Transaction Details page.
Good idea to skip the dispute submission tests and refactor in a followup issue (#7377) – I've tested these flows manually and they are working well.
| @@ -527,7 +527,8 @@ export const merchantWCP = { | |||
| openChallengeDispute: async () => { | |||
| await Promise.all( [ | |||
| evalAndClick( | |||
| 'div.wcpay-dispute-details a.components-button.is-primary' | |||
| // eslint-disable-next-line max-len | |||
| 'div.transaction-details-dispute-details-body div.transaction-details-dispute-details-body__actions button.components-button.is-primary' | |||
9 tasks
shendy-a8c
approved these changes
Oct 5, 2023
6 tasks
shendy-a8c
deleted the
fix/6928-remove-transaction-details-view-dispute-link
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6928
Changes proposed in this Pull Request
Testing instructions
4000000000000259to trigger a dispute upon purchase.With PR branch, you shouldn't see the link.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge