-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disputes: wording for disputes implying that fee has not yet been deducted #7374
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: -21 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The changelog file needs to be modified so it does not result in a changelog entry.
There are some failing e2e tests but I think that can be ignored for now because the failing tests are all dispute related and as #7088 is merged, those tests will be skipped. We will revisit re-enabling and fixing those tests in #7377.
Significance: patch | ||
Type: fix | ||
|
||
Minor wording change on unreleased feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changelog file will result an entry. I think it should be just a changelog comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just working on another PR and thought I did this one wrong, I checked the diff and it looked great 🤩 so I moved on.
Turns out I was looking at your changes! TY!
I have made the trivial change to the changelog file. |
Fixes #7254
Changes proposed in this Pull Request
Update the wording in the
Accept dispute
modal and the tooltip inSteps to resolve
to make it clear that the dispute fee has already been deducted.Accept dispute modal:
Steps to resolve - accept tooltip:
Screenshots
Before:
After:
Testing instructions
update_option( '_wcpay_feature_dispute_on_transaction_page', '1' );
in WP Console.4000000000000259
to get disputed right away.Accept dispute
button.npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge