Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disputes: wording for disputes implying that fee has not yet been deducted #7374

Merged
merged 6 commits into from
Oct 5, 2023
Merged

Disputes: wording for disputes implying that fee has not yet been deducted #7374

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
970121a
Update wording for disputes implying that fee has not yet been deducted
brucealdridge Oct 5, 2023
1896051
removing duplicated ','
brucealdridge Oct 5, 2023
cb913b3
Merge branch 'develop' into fix/7254-update-dispute-fee-text
Jinksi Oct 5, 2023
dde9558
Change changelog file so it does not produce a changelog entry.
shendy-a8c Oct 5, 2023
d31d48e
Add an extra new line to the changelog file.
shendy-a8c Oct 5, 2023
a875cae
Merge branch 'develop' into fix/7254-update-dispute-fee-text
shendy-a8c Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/fix-7254-update-dispute-fee-text
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fix

Minor wording change on unreleased feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changelog file will result an entry. I think it should be just a changelog comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just working on another PR and thought I did this one wrong, I checked the diff and it looked great 🤩 so I moved on.

Turns out I was looking at your changes! TY!

2 changes: 1 addition & 1 deletion client/payment-details/dispute-details/dispute-awaiting-response-details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ function getAcceptDisputeProps( dispute: Dispute ): AcceptDisputeProps {
sprintf(
/* translators: %s: dispute fee, <em>: emphasis HTML element. */
__(
'Accepting the dispute marks it as <em>Lost</em>. The disputed amount will be returned to the cardholder, with a %s dispute fee deducted from your account.',
'Accepting the dispute marks it as <em>Lost</em>. The disputed amount and the %s dispute fee will not be returned to you.',
'woocommerce-payments'
),
getDisputeFeeFormatted( dispute, true ) ?? '-'
Expand Down
2 changes: 1 addition & 1 deletion client/payment-details/dispute-details/dispute-steps.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export const DisputeSteps: React.FC< Props > = ( {
content={ sprintf(
// Translators: %s is a formatted currency amount, eg $10.00.
__(
`Accepting this dispute will automatically close it. Your account will be charged a %s fee, and the disputed amount will be refunded to the cardholder.`,
`Accepting this dispute will automatically close it. The disputed amount and the %s dispute fee will not be returned to you.`,
'woocommerce-payments'
),
getDisputeFeeFormatted(
Expand Down