Add WooPay button location option #7431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
mdmoore
requested review from
a team and
gpressutto5
and removed request for
a team
gpressutto5
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7370
Changes proposed in this Pull Request
Existing merchant sites that have not yet saved the WooPay settings won't have the
platform_checkout_button_locationsoption due to the option not being present in the settings. The result is that WooPay buttons won't appear on pages by default.This adds the
platform_checkout_button_locationsoption to ensure that WooPay express buttons appear on pages by default on new installations. It also ensures that the option is added on sites that don't currently have the option stored in the database.Testing instructions
Existing merchant site without the option
woocommerce_woocommerce_payments_settingsmanually in the database, removing theplatform_checkout_button_locationssetting and values and decrement the array size at the beginning of the serialized data by 1.platform_checkout_button_locationssetting was recreated with the default values ofproduct,cart, andcheckout. All settings are surface in WCPay Dev Tools under WCPay Payment Gateway settings.New merchant site
platform_checkout_button_locationsoption was created and holds the default values ofproduct,cart, andcheckoutnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge