Revert option renaming in settings controller #7565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdmoore
requested review from
a team and
timur27
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +4.49 kB (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
timur27
reviewed
Oct 27, 2023
| @@ -505,7 +505,7 @@ public function get_settings(): WP_REST_Response { | |||
| 'show_woopay_incompatibility_notice' => get_option( 'woopay_invalid_extension_found', false ), | |||
| 'woopay_custom_message' => $this->wcpay_gateway->get_option( 'platform_checkout_custom_message' ), | |||
| 'woopay_store_logo' => $this->wcpay_gateway->get_option( 'platform_checkout_store_logo' ), | |||
| 'woopay_enabled_locations' => $this->wcpay_gateway->get_option( 'platform_checkout_button_locations', array_keys( $wcpay_form_fields['platform_checkout_button_locations']['options'] ) ), | |||
| 'woopay_enabled_locations' => $this->wcpay_gateway->get_option( 'payment_request_button_locations', array_keys( $wcpay_form_fields['payment_request_button_locations']['options'] ) ), | |||
There was a problem hiding this comment.
I think the first argument had the value of platform_checkout_button_locations prior to the changes. Could you give some context if we should change it to payment_request_button_locations here? Thanks!
There was a problem hiding this comment.
Correct! Thank you for catching this. 5b5595a
|
@mdmoore The revert looks good, I tested it successfully with the JN fresh site. 1️⃣ I created a new JN store with WooPayments
2️⃣ On this new JN site, without saving any WooPay-related settings, I navigated to the shortcode checkout and the WooPay Express Checkout button was rendered as expected
|
timur27
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7554
Changes proposed in this Pull Request
This reverts the WooPay button location option renaming in the settings controller that was done in 1070cfa as part of #7431. This is done to prevent errors on plugin update due to changes in the REST controller.
The change will have no effect on the WooPay button locations settings. The list of locations will be pulled from payment request locations as they've always been in the settings controller. This can be updated again when there is a solution to plugin updates.
See p1698249967036989-slack-CGGCLBN58
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge