Prevent deleting wrong order in the duplicate payment prevention service #7441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
gpressutto5
requested review from
a team and
timur27
and removed request for
a team
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
htdat
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Thanks for investigating and working on this issue @gpressutto5.
I also manually tested with the instruction steps in this PR #5247, where I originally introduced check_against_session_processing_order. This change still works as expected.
I would suggest another condition to tighten all checks a little bit more.
Other than that, LGTM. Pre-approve so that you can ship 🚢 it whenever you'd like.
Co-authored-by: Dat Hoang <htdat@users.noreply.github.com>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR disables the create and update intent endpoints for deferred intent UPE as discussed in the thread p1696515826158069/1696515464.728129-slack-C06088FAWBS
And ensures the order that is deleted by the the duplicate payment prevention service is pending and not the same as the session order as discussed in the thread p1696576238509689/1696455674.066479-slack-C06088FAWBS
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge